On Wednesday 12 October 2005 15:49, Greg KH wrote:
> On Wed, Oct 12, 2005 at 03:30:00PM -0700, Mark Gross wrote:
> > 
> > Most significantly I moved the driver from a misc_device to a
> > platform_device.
> 
> You should still use the misc_device to register your file ops, just
> stick with the platform device for the sysfs stuff.  You need that
> misc_device in order to work properly with udev.  Have you tested this
> code on a udev-only system?

I shall tomorrow.  Most of the test cases are exercised over the sysfs 
interface, the use of the fops are not used very often.

> 
> Other than that, it looks very good.
> 
> Oh, one minor thing:
> 
> > +#include <linux/sysfs.h>
> > +#define DEBUG
> > +#include <linux/device.h>
> 
> Do you always want DEBUG to be enabled?  :)

No, but I'm glad I tested that otherwise the my problem with using dev_dbg 
with the kobj->dev devices I got from the misc_device class could have gotten 
by me.

> 
> thanks,
> 

Thank you.

-- 
--mgross
BTW: This may or may not be the opinion of my employer, more likely not.