On Wednesday 12 October 2005 18:14, Greg KH wrote:
> On Wed, Oct 12, 2005 at 04:36:29PM -0700, Mark Gross wrote:
> > No, but I'm glad I tested that otherwise the my problem with using dev_dbg 
> > with the kobj->dev devices I got from the misc_device class could have 
gotten 
> > by me.
> 
> Yeah, it's always good to test the code to make sure it compiles :)
> 
> This patch looks good, I have no objections to it.
> 
> thanks,
> 

One minor update, after testing with misc_class device for udev I found that 
it would be nice to have the sysfs file inodes all use the same base name 
"teleco_clock".

Please consider including this driver in the MM tree.

See attached.

-- 
--mgross
BTW: This may or may not be the opinion of my employer, more likely not.