From: Jesper Juhl <jesper.juhl@gmail.com>
To: "linux-kernel" <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>,
Kyle McMartin <kyle@parisc-linux.org>,
Thibaut Varene <varenet@parisc-linux.org>,
perex@suse.cz, alsa-devel@alsa-project.org,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH 13/14] Big kfree NULL check cleanup - sound
Date: Thu, 13 Oct 2005 21:30:43 +0200 [thread overview]
Message-ID: <200510132130.43423.jesper.juhl@gmail.com> (raw)
This is the sound/ part of the big kfree cleanup patch.
Remove pointless checks for NULL prior to calling kfree() in sound/.
Sorry about the long Cc: list, but I wanted to make sure I included everyone
who's code I've changed with this patch.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
Please see the initial announcement mail on LKML with subject
"[PATCH 00/14] Big kfree NULL check cleanup"
for additional details.
sound/pci/ad1889.c | 3 +--
sound/pci/rme9652/hdspm.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
--- linux-2.6.14-rc4-orig/sound/pci/rme9652/hdspm.c 2005-10-11 22:41:41.000000000 +0200
+++ linux-2.6.14-rc4/sound/pci/rme9652/hdspm.c 2005-10-13 11:49:26.000000000 +0200
@@ -3563,8 +3563,7 @@ static int snd_hdspm_free(hdspm_t * hdsp
free_irq(hdspm->irq, (void *) hdspm);
- if (hdspm->mixer)
- kfree(hdspm->mixer);
+ kfree(hdspm->mixer);
if (hdspm->iobase)
iounmap(hdspm->iobase);
--- linux-2.6.14-rc4-orig/sound/pci/ad1889.c 2005-10-11 22:41:36.000000000 +0200
+++ linux-2.6.14-rc4/sound/pci/ad1889.c 2005-10-13 11:49:33.000000000 +0200
@@ -982,8 +982,7 @@ snd_ad1889_create(snd_card_t *card,
return 0;
free_and_ret:
- if (chip)
- kfree(chip);
+ kfree(chip);
pci_disable_device(pci);
return err;
reply other threads:[~2005-10-13 19:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510132130.43423.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=varenet@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®