From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: jesper.juhl@gmail.com, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
netdev@vger.kernel.org, acme@conectiva.com.br,
ralf@linux-mips.org, greg@kroah.com, dccp@vger.kernel.org,
patrick@tykepenguin.com, jt@hpl.hp.com, sri@us.ibm.com,
andros@umich.edu, bfields@umich.edu, ncorbic@sangoma.com,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 01/14] Big kfree NULL check cleanup - net
Date: Fri, 14 Oct 2005 21:51:13 +0900 (JST) [thread overview]
Message-ID: <20051014.215113.26967183.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <200510132125.44470.jesper.juhl@gmail.com>
In article <200510132125.44470.jesper.juhl@gmail.com> (at Thu, 13 Oct 2005 21:25:43 +0200), Jesper Juhl <jesper.juhl@gmail.com> says:
> --- linux-2.6.14-rc4-orig/net/ipv4/netfilter/ip_nat_snmp_basic.c 2005-10-11 22:41:33.000000000 +0200
> +++ linux-2.6.14-rc4/net/ipv4/netfilter/ip_nat_snmp_basic.c 2005-10-13 11:31:09.000000000 +0200
> @@ -1161,8 +1161,7 @@ static int snmp_parse_mangle(unsigned ch
>
> if (!snmp_object_decode(&ctx, obj)) {
> if (*obj) {
> - if ((*obj)->id)
> - kfree((*obj)->id);
> + kfree((*obj)->id);
> kfree(*obj);
> }
> kfree(obj);
Maybe:
if (*obj)
kfree((*obj)->id);
kfree(obj);
Otherwise;
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
--yoshfuji
prev parent reply other threads:[~2005-10-14 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 19:25 Jesper Juhl
2005-10-14 9:50 ` Marcel Holtmann
2005-10-14 12:02 ` Jesper Juhl
2005-10-14 12:51 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051014.215113.26967183.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=acme@conectiva.com.br \
--cc=akpm@osdl.org \
--cc=andros@umich.edu \
--cc=bfields@umich.edu \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=greg@kroah.com \
--cc=jesper.juhl@gmail.com \
--cc=jt@hpl.hp.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ncorbic@sangoma.com \
--cc=netdev@vger.kernel.org \
--cc=patrick@tykepenguin.com \
--cc=ralf@linux-mips.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®