From: Randall Nortman <linuxkernellist@wonderclown.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Regression in 2.6.13 in USB generic serial driver
Date: Thu, 13 Oct 2005 21:42:56 -0400 [thread overview]
Message-ID: <20051014014255.GN8982@li2-47.members.linode.com> (raw)
Kernel version 2.6.13 introduced a regression (vs. 2.6.12.6) in the
generic USB serial converter driver. The regression manifests, as far
as I can tell, whenever you attempt to write to the device. The
symptom is that the write never completes (write() returns 0, or
blocks). I'm pretty sure this will happen with all hardware, but I
only have my hardware to test with (amd64 host interfacing to a
custom-built USB device based on an Atmel AT91SAM7X256 arm7tdmi chip's
built-in USB transceiver).
The patch (vs. vanilla 2.6.13.4) is rather straightforward:
===================================================================
diff -ru linux-2.6.13.4/drivers/usb/serial/generic.c linux-2.6.13.4-fixed/drivers/usb/serial/generic.c
--- linux-2.6.13.4/drivers/usb/serial/generic.c 2005-10-10 14:54:29.000000000 -0400
+++ linux-2.6.13.4-fixed/drivers/usb/serial/generic.c 2005-10-13 21:34:54.000000000 -0400
@@ -223,7 +223,7 @@
dbg("%s - port %d", __FUNCTION__, port->number);
if (serial->num_bulk_out) {
- if (port->write_urb_busy)
+ if (!(port->write_urb_busy))
room = port->bulk_out_size;
}
===================================================================
Please let me know if I'm missing something. Otherwise, do I need to
do anything in particular to get a maintainer to accept the patch?
(I'm a long-time user, first-time patcher, so forgive my ignorance
about procedures.)
--
Randall
next reply other threads:[~2005-10-14 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 1:42 Randall Nortman [this message]
2005-10-14 1:59 ` Chris Wright
2005-10-14 4:20 ` [PATCH] usbserial: Regression " Randall Nortman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051014014255.GN8982@li2-47.members.linode.com \
--to=linuxkernellist@wonderclown.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome