From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750826AbVJNSKw (ORCPT ); Fri, 14 Oct 2005 14:10:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750828AbVJNSKw (ORCPT ); Fri, 14 Oct 2005 14:10:52 -0400 Received: from mail.kroah.org ([69.55.234.183]:56235 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S1750826AbVJNSKv (ORCPT ); Fri, 14 Oct 2005 14:10:51 -0400 Date: Fri, 14 Oct 2005 11:10:24 -0700 From: Greg KH To: Christian Krause Cc: Chris Wright , kernel-stuff@comcast.net, stable@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [stable] Re: [PATCH] Re: bug in handling of highspeed usb HID devices Message-ID: <20051014181024.GB17179@kroah.com> References: <101320051953.12930.434EBB460007F30B0000328222007589429D0E050B9A9D0E99@comcast.net> <20051013212518.GY5856@shell0.pdx.osdl.net> <20051014171326.GA16496@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 14, 2005 at 07:46:02PM +0200, Christian Krause wrote: > On Fri, 14 Oct 2005 10:13:26 -0700, Greg KH wrote: > > > On Thu, Oct 13, 2005 at 02:25:18PM -0700, Chris Wright wrote: > >> * kernel-stuff@comcast.net (kernel-stuff@comcast.net) wrote: > >> > This seems to be -stable material since it's a clear cut bug with bad > >> > consequences. > >> > > >> > Chris Wright - is the below patch acceptable for -stable? > > > Also, I don't think this should go into -stable, as there are no > > high-speed HID devices available right now, so it really isn't affecting > > anyone :) > > No, that's no correct. There are such devices: > > Newer KVM-over-IP appliances, like the Avocent's DSR2030 emulates > keyboard, mouse and a mass storage device over USB. I've tested this > specific device with linux and the USB transfers are Highspeed and the > USB device has one interface which is HID. So there are Highspeed USB > devices out there. Ah, ok, thanks, I wasn't aware of these devices. > With all respect, but I don't really understand why this is important. > The linux kernel clearly violates the USB specification. The calculation of > the real polling interval for interrupt endpoints is > i = 2^(bInterval-1) (according to USB 2.0 spec, chapter 9.6.6) and _not_ > i = 2^((2^(bInterval-1))-1) as it is calculated in linux. > This is clearly a bug in linux and should be fixed. No one is arguing that it shouldn't be. thanks, greg k-h