From: Francois Romieu <romieu@fr.zoreil.com>
To: Suzanne Wood <suzannew@cs.pdx.edu>
Cc: linux-kernel@vger.kernel.org, g4klx@g4klx.demon.co.uk,
hch@infradead.org, jreuter@yaina.de, paulmck@us.ibm.com,
walpole@cs.pdx.edu
Subject: Re: [RFC][PATCH] rcu in drivers/net/hamradio
Date: Sat, 15 Oct 2005 13:24:30 +0200 [thread overview]
Message-ID: <20051015112430.GA3793@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200510140804.j9E84nwG026920@rastaban.cs.pdx.edu>
Suzanne Wood <suzannew@cs.pdx.edu> :
[...]
> (3) bpq_free_device() calls list_del_rcu() which, according
> to list.h, requires synchronize_rcu() which can block or
> call_rcu() or call_rcu_bh() which cannot block.
> None of these is called anywhere in the directory drivers/net,
> so synchronize_irq() may address this.
> (synchronize_sched() is called in drivers/net/sis190.c and
> r8169.c with FIXME comment about synchronize_irq().)
Same author for both. The code (driver specific) can be issued from
userspace and it needs to wait for running hard_start_xmit to
complete. Afaik synchronize_irq() is not adequate and the FIXME
should go.
--
Ueimor
next prev parent reply other threads:[~2005-10-15 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 8:04 Suzanne Wood
2005-10-14 13:37 ` Herbert Xu
2005-10-15 11:24 ` Francois Romieu [this message]
2005-10-15 12:03 ` Herbert Xu
2005-10-14 16:38 Suzanne Wood
2005-10-14 22:36 ` Herbert Xu
2005-10-15 7:57 Suzanne Wood
2005-10-15 8:05 ` Herbert Xu
2005-10-15 22:24 Suzanne Wood
2005-10-16 7:21 ` Herbert Xu
2005-10-16 17:03 Suzanne Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051015112430.GA3793@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=g4klx@g4klx.demon.co.uk \
--cc=hch@infradead.org \
--cc=jreuter@yaina.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=suzannew@cs.pdx.edu \
--cc=walpole@cs.pdx.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®