[snip snip] On Wed, 12 Oct 2005 15:34, Andrew Morton wrote: > Why use the "zone with most free pages"? Generally it would be better to > use up ZONE_HIGHMEM first: ZONE_NORMAL is valuable. > I'd just not bother with the locking at all here. > kthread(), please. > Might be able to use a boring old wake_up_process() here rather than a > waitqueue. > Is the timer actually needed? Could just do schedule_timeout() in > kprefetchd()? Ok how's this look? On top of your patches. Cheers, Con