From: Mattia Dongili <malattia@linux.it>
To: emard@softhome.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: uinput crash and fix
Date: Sun, 16 Oct 2005 00:01:15 +0200 [thread overview]
Message-ID: <20051015220115.GG3564@inferi.kami.home> (raw)
In-Reply-To: <20051015212911.GA25752@tink>
On Sat, Oct 15, 2005 at 11:29:12PM +0200, emard@softhome.net wrote:
> HI
[...]
> req = uinput_request_find(udev, ff_up.request_id);
> - if (!(req && req->code == UI_FF_UPLOAD && req->u.effect)) {
> + if (!req) {
out of curiosity, instead of adding a whole if block wouldn't be easier
to just write
if (!req || !(req->code == UI_FF_UPLOAD && req->u.effect)) {
in order to evaulate !req first and eventually dereference it?
--
mattia
:wq!
next prev parent reply other threads:[~2005-10-15 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-15 21:29 emard
2005-10-15 22:01 ` Mattia Dongili [this message]
2005-10-15 22:48 ` Mattia Dongili
2005-10-15 22:51 ` emard
2005-10-16 11:51 ` uinput crash and NO FIX YET emard
2005-10-16 21:12 ` emard
2005-10-16 22:06 ` [PATCH] uinput crash maybe this is the FIX emard
2005-10-17 5:55 ` Dmitry Torokhov
2005-10-17 7:16 ` emard
2005-10-17 21:28 ` Let this uinput patch go to 2.6.14 emard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051015220115.GG3564@inferi.kami.home \
--to=malattia@linux.it \
--cc=emard@softhome.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®