From: WU Fengguang <wfg@mail.ustc.edu.cn>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: Fw: Re: 2.6.14-rc4-mm1
Date: Mon, 17 Oct 2005 16:15:34 +0800 [thread overview]
Message-ID: <20051017081534.GA4493@mail.ustc.edu.cn> (raw)
In-Reply-To: <1129533808.7620.70.camel@gaston>
On Mon, Oct 17, 2005 at 05:23:27PM +1000, Benjamin Herrenschmidt wrote:
> Does that updated patch fixes it ?
Lots of rejects, so I manually applied the relevant part in nv_proto.h.
It worked, though there were warnings:
drivers/video/nvidia/nv_setup.c: In function `NVCommonSetup':
drivers/video/nvidia/nv_setup.c:408: warning: statement with no effect
drivers/video/nvidia/nv_setup.c:496: warning: statement with no effect
drivers/video/nvidia/nv_setup.c:504: warning: statement with no effect
> +#define nvidia_probe_i2c_connector(p, c, edid) (-1)
> +#define nvidia_probe_of_connector(p, c, edid) (-1)
Do you mean TRUE/SUCCESS here with (-1)?
>
> Index: linux-work/drivers/video/nvidia/nv_proto.h
> ===================================================================
> --- linux-work.orig/drivers/video/nvidia/nv_proto.h 2005-10-13 13:46:13.000000000 +1000
> +++ linux-work/drivers/video/nvidia/nv_proto.h 2005-10-17 17:22:28.000000000 +1000
> @@ -31,7 +31,7 @@
> void NVLockUnlock(struct nvidia_par *par, int);
>
> /* in nvidia-i2c.c */
> -#if defined(CONFIG_FB_NVIDIA_I2C) || defined (CONFIG_PPC_OF)
> +#ifdef CONFIG_FB_NVIDIA_I2C
> void nvidia_create_i2c_busses(struct nvidia_par *par);
> void nvidia_delete_i2c_busses(struct nvidia_par *par);
> int nvidia_probe_i2c_connector(struct fb_info *info, int conn,
> @@ -39,10 +39,14 @@
> #else
> #define nvidia_create_i2c_busses(...)
> #define nvidia_delete_i2c_busses(...)
> -#define nvidia_probe_i2c_connector(p, c, edid) \
> -do { \
> - *(edid) = NULL; \
> -} while(0)
> +#define nvidia_probe_i2c_connector(p, c, edid) (-1)
> +#endif
> +
> +#ifdef CONFIG_FB_OF
> +int nvidia_probe_of_connector(struct fb_info *info, int conn,
> + u8 ** out_edid);
> +#else
> +#define nvidia_probe_of_connector(p, c, edid) (-1)
> #endif
Regards,
Wu Fengguang
next prev parent reply other threads:[~2005-10-17 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051017001321.2358f341.akpm@osdl.org>
2005-10-17 7:23 ` Benjamin Herrenschmidt
2005-10-17 8:15 ` WU Fengguang [this message]
2005-10-17 8:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051017081534.GA4493@mail.ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome