From: Greg KH <greg@kroah.com>
To: Jonathan Mayer <jonmayer@google.com>
Cc: dtor_core@ameritech.net, linux-kernel@vger.kernel.org,
Patrick Mochel <mochel@digitalimplant.org>
Subject: Re: [PATCH] added sysdev attribute to sysdev show/store methods - for linux-2.6.13.4
Date: Thu, 20 Oct 2005 21:07:14 -0700 [thread overview]
Message-ID: <20051021040713.GA17827@kroah.com> (raw)
In-Reply-To: <4a45da430510201742q1c4d5532oe64a77be72e7eff8@mail.google.com>
On Thu, Oct 20, 2005 at 05:42:50PM -0700, Jonathan Mayer wrote:
> > It is a good idea, if someone needs access to that attribute
> > information. But for now, no one does. When they do, I'll be glad to
> > accept the patch.
>
> Hi Greg,
>
> My only concern, then, is that by the time somebody needs this patch,
> the set of sysdev objects will have grown, requiring a big patch
> instead of a small one.
So? That's not a big deal, split it into more pieces. That's what was
done when people did the same for the device attributes.
> I would also argue that even existing sysdev objects could be
> rewritten and cleaned up slightly (remove proliferation of methods) by
> using the attribute.
Now that would be a justification for accepting the patch, and is why I
took it for the device attributes.
> If you like, I could try doing that and submit it as part of this patch...
That would be fine.
thanks,
greg k-h
next prev parent reply other threads:[~2005-10-21 4:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-20 21:47 Jonathan Mayer
2005-10-20 21:59 ` Dmitry Torokhov
2005-10-20 22:03 ` Jonathan Mayer
2005-10-20 23:03 ` Dmitry Torokhov
2005-10-20 23:07 ` Jonathan Mayer
2005-10-21 0:26 ` Greg KH
2005-10-21 0:42 ` Jonathan Mayer
2005-10-21 4:07 ` Greg KH [this message]
2005-10-20 22:00 ` Jonathan Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051021040713.GA17827@kroah.com \
--to=greg@kroah.com \
--cc=dtor_core@ameritech.net \
--cc=jonmayer@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®