From: Tejun Heo <htejun@gmail.com>
To: axboe@suse.de, linux-kernel@vger.kernel.org
Subject: [PATCH linux-block-2.6:generic-dispatch] kill max_back_kb handling
Date: Mon, 24 Oct 2005 12:27:31 +0900 [thread overview]
Message-ID: <20051024032731.GA14202@htj.dyndns.org> (raw)
Hello, Jens.
This patch kills max_back_kb handling from elv_dispatch_sort() and
kills max_back_kb field from struct request_queue. The implementation
was broken (subtracted bytes from blocks) and the usefulness of the
feature is doubtful.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/block/elevator.c b/drivers/block/elevator.c
--- a/drivers/block/elevator.c
+++ b/drivers/block/elevator.c
@@ -136,7 +136,6 @@ static int elevator_attach(request_queue
q->elevator = eq;
q->end_sector = 0;
q->boundary_rq = NULL;
- q->max_back_kb = 0;
if (eq->ops->elevator_init_fn)
ret = eq->ops->elevator_init_fn(q, eq);
@@ -227,16 +226,13 @@ void elevator_exit(elevator_t *e)
void elv_dispatch_sort(request_queue_t *q, struct request *rq)
{
sector_t boundary;
- unsigned max_back;
struct list_head *entry;
if (q->last_merge == rq)
q->last_merge = NULL;
boundary = q->end_sector;
- max_back = q->max_back_kb * 2;
- boundary = boundary > max_back ? boundary - max_back : 0;
-
+
list_for_each_prev(entry, &q->queue_head) {
struct request *pos = list_entry_rq(entry);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -339,7 +339,6 @@ struct request_queue
*/
sector_t end_sector;
struct request *boundary_rq;
- unsigned int max_back_kb;
/*
* Auto-unplugging state
next reply other threads:[~2005-10-24 3:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 3:27 Tejun Heo [this message]
2005-10-24 3:30 ` Tejun Heo
2005-10-24 6:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051024032731.GA14202@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome