mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Simon.Derr@bull.net, linux-kernel@vger.kernel.org, ak@suse.de,
	torvalds@osdl.org, clameter@sgi.com
Subject: Re: [PATCH 01/02] cpuset bitmap and mask remap operators
Date: Mon, 24 Oct 2005 07:37:15 -0700	[thread overview]
Message-ID: <20051024073715.02e1f3e3.pj@sgi.com> (raw)
In-Reply-To: <20051024013713.25770d14.akpm@osdl.org>

Andrew wrote:
> hm.  That hides what's really going on from the programmer.
> 
> Oh well - you're the only guy who dinks with that stuff anyway ;)

Halloween comes a week early to the Morton household.  The patch from
hell, circa April 2004, lives on to haunt Andrew <grin>.

By the time we (wli, rusty, colpatch, ...) incorporated the following
various constraints on these cpumask/nodemask macros, we were fortunate
to only violate the "obvious to the programmer" constraint on the
implementation internals:
  - near perfect code gen on small systems (1 word masks)
  - near perfect code gen on large systems (multiword masks)
  - type checking on arguments
  - keep the existing macro-style calling conventions:
	cpus_and(result, input1, input2)
  - a single bitmap internal implementation - the rest just wrappers
  - dramatic shinkage of kernel source devoted to this stuff
  - reduction in kernel text size across all architectures.

Probably it is best that we not ask too many questions at this time ;).

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

      reply	other threads:[~2005-10-24 14:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-24  7:27 Paul Jackson
2005-10-24  7:27 ` [PATCH 02/02] cpuset automatic numa mempolicy rebinding Paul Jackson
2005-10-24  8:36   ` Dave Hansen
2005-10-24 14:47     ` Paul Jackson
2005-10-24 14:52       ` Dave Hansen
2005-10-24 15:02         ` Paul Jackson
2005-10-24  7:48 ` [PATCH 01/02] cpuset bitmap and mask remap operators Andrew Morton
2005-10-24  8:16   ` Paul Jackson
2005-10-24  8:37     ` Andrew Morton
2005-10-24 14:37       ` Paul Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051024073715.02e1f3e3.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=Simon.Derr@bull.net \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome