From: Matt Mackall <mpm@selenic.com>
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: Hareesh Nagarajan <hnagar2@gmail.com>,
linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: [TRIVIAL] Error checks omitted in init_tmpfs() in mm/tiny-shmem.c
Date: Mon, 24 Oct 2005 14:08:54 -0700 [thread overview]
Message-ID: <20051024210854.GK26160@waste.org> (raw)
In-Reply-To: <20051024210047.GG17764@granada.merseine.nu>
On Mon, Oct 24, 2005 at 11:00:47PM +0200, Muli Ben-Yehuda wrote:
> On Mon, Oct 24, 2005 at 01:45:18PM -0700, Matt Mackall wrote:
>
> > > --- linux-2.6.13.4/mm/tiny-shmem.c 2005-10-10 13:54:29.000000000 -0500
> > > +++ linux-2.6.13.4-edit/mm/tiny-shmem.c 2005-10-24 03:43:38.614071000 -0500
> > > @@ -31,12 +31,18 @@
> > >
> > > static int __init init_tmpfs(void)
> > > {
> > > - register_filesystem(&tmpfs_fs_type);
> > > + int error;
> > > +
> > > + error = register_filesystem(&tmpfs_fs_type);
> > > + BUG_ON(error);
> >
> > Can we just do BUG_ON(register_filesystem() != 0)?
>
> It seems a little risky to me to rely on a macro always evaluating its
> arguments, even though this one does on every kernel version I
> checked.
You must have missed my patch on 1 April that allows turning off all
kernel bugs. It makes sure the arguments are still evaluated.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-10-24 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 5:29 Hareesh Nagarajan
2005-10-24 7:09 ` Matt Mackall
2005-10-24 8:56 ` Hareesh Nagarajan
2005-10-24 20:45 ` Matt Mackall
2005-10-24 21:00 ` Muli Ben-Yehuda
2005-10-24 21:08 ` Matt Mackall [this message]
2005-10-25 0:16 ` Hareesh Nagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051024210854.GK26160@waste.org \
--to=mpm@selenic.com \
--cc=ak@suse.de \
--cc=hnagar2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®