From: Andrew Morton <akpm@osdl.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: rolandd@cisco.com, laurent.riffard@free.fr,
linux-kernel@vger.kernel.org, greg@kroah.com,
rmk+lkml@arm.linux.org.uk
Subject: Re: [RFC patch 2/3] remove pci_driver.owner and .name fields
Date: Wed, 26 Oct 2005 14:35:04 -0700 [thread overview]
Message-ID: <20051026143504.15064020.akpm@osdl.org> (raw)
In-Reply-To: <20051026212127.GU7992@ftp.linux.org.uk>
Al Viro <viro@ftp.linux.org.uk> wrote:
>
> On Wed, Oct 26, 2005 at 02:05:08PM -0700, Roland Dreier wrote:
> > > - .name = "DAC960",
> > > + .driver = {
> > > + .name = "DAC960",
> > > + },
> >
> > This change looks like a (rather ugly) step backwards. Maybe it would
> > be better to add the name as a parameter to pci_register_driver?
>
> It looks stupid in the first place - what's wrong with
> .driver.name = "DAC960",
> instead of that mess?
gcc-2.95.x doesn't support that.
next prev parent reply other threads:[~2005-10-26 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 20:48 [RFC patch 0/3] " Laurent riffard
2005-10-26 20:48 ` [RFC patch 1/3] " Laurent riffard
2005-10-26 21:20 ` Al Viro
2005-10-26 22:53 ` Laurent Riffard
2005-10-26 20:48 ` [RFC patch 2/3] " Laurent riffard
2005-10-26 21:05 ` Roland Dreier
2005-10-26 21:21 ` Al Viro
2005-10-26 21:30 ` Roland Dreier
2005-10-26 21:35 ` Andrew Morton [this message]
2005-10-26 20:48 ` [RFC patch 3/3] " Laurent riffard
2005-10-26 21:11 ` Greg KH
2005-10-26 22:22 ` Laurent Riffard
2005-10-26 22:26 ` Greg KH
2005-10-26 22:57 ` Laurent Riffard
2005-10-26 21:17 ` [RFC patch 0/3] " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051026143504.15064020.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rolandd@cisco.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®