mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Ingo Molnar'" <mingo@elte.hu>,
	"Nick Piggin" <nickpiggin@yahoo.com.au>,
	"Andrew Morton" <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: better wake-balancing: respin
Date: Wed, 26 Oct 2005 18:24:25 -0700	[thread overview]
Message-ID: <200510270124.j9R1OPg27107@unix-os.sc.intel.com> (raw)

Once upon a time, this patch was in -mm tree (2.6.13-mm1):
http://marc.theaimsgroup.com/?l=linux-kernel&m=112265450426975&w=2

It is neither in Linus's official tree, nor it is in -mm anymore.

I guess I missed the objection for dropping the patch.  I'm bringing
up this discussion again.  The wake-up path is a lot hotter on numa
system running database benchmark.  Even on a moderate 8P numa box,
__wake_up and try_to_wake_up is showing up as #1 and #4 hottest kernel
functions.  While on a comparable 4P smp box, these two functions are
#5 and #9 respectively.

I think situation will be worse on 32P numa box in the wake up path.
I don't have any measurement on 32P setup yet, because 8P numa
performance sucks at the moment and it is a blocker for us before
proceed any bigger setup.


Execution profile for 8P numa box [1]:

   Symbol              Clockticks Inst. Retired   L3 Misses
#1 __wake_up           8.08%      1.88%           4.67%
#2 finish_task_switch  7.53%      18.11%          5.82%
#3 __make_request      6.87%      2.09%           4.35%
#4 try_to_wake_up      5.57%      0.64%           3.10%



Execution profile for 4P SMP box [2]:

   Symbol              Clockticks
#5 __wake_up           3.57%
#9 try_to_wake_up      2.38%

My question is: what was the reason this patch is dropped and what
can we do to improve wake-up performance?  In my opinion, we should
simply put the task on the CPU it was previously ran and have
rebalance_tick and load_balance_newidle to balance out the load.

- Ken


[1] 8 processor: 1.6 GHz Itanium2 processor, 9M L3. 256 GB memory
[2] 4 processor: 1.6 GHz Itanium2 processor, 9M L3. 128 GB memory


             reply	other threads:[~2005-10-27  1:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-27  1:24 Chen, Kenneth W [this message]
2005-10-28  7:40 ` Ingo Molnar
2005-10-28 22:34   ` Chen, Kenneth W
2005-10-28  9:17 ` Nick Piggin
2005-10-28 10:08   ` Ingo Molnar
2005-10-28 11:03     ` Nick Piggin
2005-10-28 14:37       ` Ingo Molnar
2005-10-28 15:04         ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200510270124.j9R1OPg27107@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®