From: Lennert Buytenhek <buytenh@wantstofly.org>
To: John Bowler <jbowler@acm.org>
Cc: "'Deepak Saxena'" <dsaxena@plexity.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] 2.6.14: NSLU2 machine support
Date: Fri, 28 Oct 2005 11:24:13 +0200 [thread overview]
Message-ID: <20051028092412.GA27155@xi.wantstofly.org> (raw)
In-Reply-To: <001501c5db94$40eca320$1001a8c0@kalmiopsis>
On Fri, Oct 28, 2005 at 12:50:22AM -0700, John Bowler wrote:
> +static irqreturn_t nslu2_reset_handler(int irq, void *dev_id, struct pt_regs *regs)
> +{
> + /* FIXME This doesn't reset the NSLU2. It powers it off.
> + * Close enough, since reset is unreliable
> + */
Is this comment still valid?
Looks good otherwise!
--L
prev parent reply other threads:[~2005-10-28 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-28 7:50 John Bowler
2005-10-28 8:07 ` Russell King
2005-10-28 9:24 ` Lennert Buytenhek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051028092412.GA27155@xi.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=dsaxena@plexity.net \
--cc=jbowler@acm.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®