On Friday, October 28, 2005 9:50 pm, Roland Dreier wrote: > I don't really understand why gcc gives the error it does, but > without this patch, when building with CONFIG_HOTPLUG=n, I get errors > like: > > CC arch/x86_64/pci/../../i386/pci/fixup.o > arch/x86_64/pci/../../i386/pci/fixup.c: In function > `pci_fixup_i450nx': arch/x86_64/pci/../../i386/pci/fixup.c:13: error: > pci_fixup_i450nx causes a section type conflict > > The change is obviously correct: an array should be declared > __devinitdata rather that __devinit. Oops, yeah I think this is correct. We should also mark toshiba_line_size as __devinitdata. Patch relative to yours. Thanks, Jesse Signed-off-by: Jesse Barnes