mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Greg KH <gregkh@suse.de>
Cc: Roland Dreier <rolandd@cisco.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] toshiba_ohci1394_dmi_table should be __devinitdata, not __devinit
Date: Sat, 29 Oct 2005 21:19:13 -0700	[thread overview]
Message-ID: <200510292119.13959.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20051029195749.GB14978@suse.de>

On Saturday, October 29, 2005 12:57 pm, Greg KH wrote:
> > Oops, yeah I think this is correct.  We should also mark
> > toshiba_line_size as __devinitdata.  Patch relative to yours.
>
> Why?  Is it really worth it?  2 bytes?  Ick.

More for consistency than anything else.  No biggie.

> It's time to just make CONFIG_HOTPLUG always on to keep messes like
> this from happening...

Fine with me!

Jesse

      reply	other threads:[~2005-10-30  4:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-29  4:50 Roland Dreier
2005-10-29 14:43 ` Jesse Barnes
2005-10-29 19:57   ` Greg KH
2005-10-30  4:19     ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200510292119.13959.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rolandd@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®