From: Ben Dooks <ben-linux@fluff.org>
To: hirofumi@mail.parknet.co.jp, linux-kernel@vger.kernel.org
Subject: fs/fat - fix sparse warning
Date: Mon, 31 Oct 2005 11:36:39 +0000 [thread overview]
Message-ID: <20051031113639.GA30667@home.fluff.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]
move fat_cache_init/fat_cache_destroy to a common
header file in fs/fat so that inode.c and cache.c
see the same definition, and to stop warnings
from sparse about undeclared functions
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
diff -urpN -X ../dontdiff linux-2.6.14-git3/fs/fat/cache.c linux-2.6.14-git3-bjd1/fs/fat/cache.c
--- linux-2.6.14-git3/fs/fat/cache.c 2005-09-01 21:02:38.000000000 +0100
+++ linux-2.6.14-git3-bjd1/fs/fat/cache.c 2005-10-31 11:31:32.000000000 +0000
@@ -12,6 +12,8 @@
#include <linux/msdos_fs.h>
#include <linux/buffer_head.h>
+#include "cache.h"
+
/* this must be > 0. */
#define FAT_MAX_CACHE 8
diff -urpN -X ../dontdiff linux-2.6.14-git3/fs/fat/cache.h linux-2.6.14-git3-bjd1/fs/fat/cache.h
--- linux-2.6.14-git3/fs/fat/cache.h 1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.14-git3-bjd1/fs/fat/cache.h 2005-10-31 11:32:37.000000000 +0000
@@ -0,0 +1,8 @@
+/* linux/fs/fat/cache.h
+ *
+ * Written 1992,1993 by Werner Almesberger
+ * header, 2005, Ben Dooks
+*/
+
+extern int __init fat_cache_init(void);
+extern void fat_cache_destroy(void);
diff -urpN -X ../dontdiff linux-2.6.14-git3/fs/fat/inode.c linux-2.6.14-git3-bjd1/fs/fat/inode.c
--- linux-2.6.14-git3/fs/fat/inode.c 2005-10-28 11:28:31.000000000 +0100
+++ linux-2.6.14-git3-bjd1/fs/fat/inode.c 2005-10-31 11:32:29.000000000 +0000
@@ -24,6 +24,8 @@
#include <linux/parser.h>
#include <asm/unaligned.h>
+#include "cache.h"
+
#ifndef CONFIG_FAT_DEFAULT_IOCHARSET
/* if user don't select VFAT, this is undefined. */
#define CONFIG_FAT_DEFAULT_IOCHARSET ""
@@ -1346,9 +1348,6 @@ out_fail:
EXPORT_SYMBOL(fat_fill_super);
-int __init fat_cache_init(void);
-void fat_cache_destroy(void);
-
static int __init init_fat_fs(void)
{
int err;
[-- Attachment #2: 2614-fat-fix-cache-decl.patch --]
[-- Type: text/plain, Size: 1518 bytes --]
diff -urpN -X ../dontdiff linux-2.6.14-git3/fs/fat/cache.c linux-2.6.14-git3-bjd1/fs/fat/cache.c
--- linux-2.6.14-git3/fs/fat/cache.c 2005-09-01 21:02:38.000000000 +0100
+++ linux-2.6.14-git3-bjd1/fs/fat/cache.c 2005-10-31 11:31:32.000000000 +0000
@@ -12,6 +12,8 @@
#include <linux/msdos_fs.h>
#include <linux/buffer_head.h>
+#include "cache.h"
+
/* this must be > 0. */
#define FAT_MAX_CACHE 8
diff -urpN -X ../dontdiff linux-2.6.14-git3/fs/fat/cache.h linux-2.6.14-git3-bjd1/fs/fat/cache.h
--- linux-2.6.14-git3/fs/fat/cache.h 1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.14-git3-bjd1/fs/fat/cache.h 2005-10-31 11:32:37.000000000 +0000
@@ -0,0 +1,8 @@
+/* linux/fs/fat/cache.h
+ *
+ * Written 1992,1993 by Werner Almesberger
+ * header, 2005, Ben Dooks
+*/
+
+extern int __init fat_cache_init(void);
+extern void fat_cache_destroy(void);
diff -urpN -X ../dontdiff linux-2.6.14-git3/fs/fat/inode.c linux-2.6.14-git3-bjd1/fs/fat/inode.c
--- linux-2.6.14-git3/fs/fat/inode.c 2005-10-28 11:28:31.000000000 +0100
+++ linux-2.6.14-git3-bjd1/fs/fat/inode.c 2005-10-31 11:32:29.000000000 +0000
@@ -24,6 +24,8 @@
#include <linux/parser.h>
#include <asm/unaligned.h>
+#include "cache.h"
+
#ifndef CONFIG_FAT_DEFAULT_IOCHARSET
/* if user don't select VFAT, this is undefined. */
#define CONFIG_FAT_DEFAULT_IOCHARSET ""
@@ -1346,9 +1348,6 @@ out_fail:
EXPORT_SYMBOL(fat_fill_super);
-int __init fat_cache_init(void);
-void fat_cache_destroy(void);
-
static int __init init_fat_fs(void)
{
int err;
next reply other threads:[~2005-10-31 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 11:36 Ben Dooks [this message]
2005-10-31 13:27 ` Alexey Dobriyan
2005-10-31 14:15 ` OGAWA Hirofumi
2005-11-02 18:04 ` Adrian Bunk
2005-11-02 18:39 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031113639.GA30667@home.fluff.org \
--to=ben-linux@fluff.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®