From: Andrew Morton <akpm@osdl.org>
To: matthieu castet <castet.matthieu@free.fr>
Cc: linux-usb-devel@lists.sourceforge.net,
usbatm@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Eagle and ADI 930 usb adsl modem driver
Date: Wed, 2 Nov 2005 16:34:23 +1100 [thread overview]
Message-ID: <20051102163423.460fe9c5.akpm@osdl.org> (raw)
In-Reply-To: <436776C6.3040900@free.fr>
matthieu castet <castet.matthieu@free.fr> wrote:
>
> >>+
> >>+ *cmvs = (struct uea_cmvs *)(data + 1);
> >
> >
> > That's a bit rude - asking the compiler to perform a structure copy from an
> > odd address. memcpy() would be saner.
> >
> Could you elaborate a bit more ?
> I don't see where there is a copy.
> *cmvs is a pointer to the structure, not the structure. And when we
> parse the structure, we use get_unaligned functions.
>
>
Ah, I misread the code.
next prev parent reply other threads:[~2005-11-02 6:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 22:37 matthieu castet
2005-10-31 23:58 ` Andrew Morton
2005-11-01 12:40 ` Duncan Sands
2005-11-01 13:04 ` David Woodhouse
2005-11-01 13:12 ` Marco d'Itri
2005-11-02 7:42 ` Duncan Sands
2005-11-02 7:45 ` David Woodhouse
2005-11-02 8:02 ` Duncan Sands
2005-11-02 10:46 ` Roman Kagan
2005-11-02 11:01 ` Duncan Sands
2005-11-01 13:49 ` matthieu castet
2005-11-02 5:29 ` Andrew Morton
2005-11-02 22:27 ` Greg KH
2005-11-02 7:45 ` Duncan Sands
2005-11-01 14:08 ` matthieu castet
2005-11-02 5:34 ` Andrew Morton [this message]
2005-11-02 7:47 ` Duncan Sands
2005-11-01 22:45 ` Greg KH
2005-11-02 7:54 ` Duncan Sands
2005-11-02 8:03 ` Greg KH
2005-11-02 8:45 ` [linux-usb-devel] " Oliver Neukum
2005-11-02 8:52 ` Duncan Sands
2005-11-02 21:39 ` Greg KH
2005-11-02 21:37 ` Greg KH
2005-11-02 15:56 ` Alan Stern
2005-11-02 20:15 ` matthieu castet
2005-11-02 21:18 ` matthieu castet
2005-11-07 17:47 ` Greg KH
2005-11-06 18:44 ` matthieu castet
2005-11-07 17:47 ` Greg KH
2005-11-07 17:46 ` Greg KH
2005-11-07 18:47 ` matthieu castet
2005-11-07 22:27 ` matthieu castet
2005-11-07 23:02 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102163423.460fe9c5.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=usbatm@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®