From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Russell King <linux@arm.linux.org.uk>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: kernel library ordering
Date: Wed, 2 Nov 2005 22:49:31 +0100 [thread overview]
Message-ID: <20051102214931.GA18668@mars.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0510311333320.5288@localhost.localdomain>
On Mon, Oct 31, 2005 at 01:48:49PM -0500, Nicolas Pitre wrote:
>
> In the latest kernel, there is an optimized sha1 routine
> (arch/arm/lib/sha1.S) meant to override the generic one in lib/sha1.c.
>
> The problem is that lib/lib.a is listed _before_ arch/arm/lib/lib.a in
> the link argument list so the architecture specific lib functions are
> not picked up in priority.
>
> To work around this the following patch is needed:
>
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -142,7 +142,7 @@ drivers-$(CONFIG_OPROFILE) += arch/
> drivers-$(CONFIG_ARCH_CLPS7500) += drivers/acorn/char/
> drivers-$(CONFIG_ARCH_L7200) += drivers/acorn/char/
>
> -libs-y += arch/arm/lib/
> +libs-y := arch/arm/lib/ $(libs-y)
>
> # Default target when executing plain make
> ifeq ($(CONFIG_XIP_KERNEL),y)
>
> However I was wondering if there should be a better and generic way to
> fix that.
This looks like an obvious way to achive correct ordering.
We could change it so arch defines always took precedence but
the above is so simple that it is not worth the effort.
Sam
prev parent reply other threads:[~2005-11-02 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 18:48 Nicolas Pitre
2005-11-02 21:49 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102214931.GA18668@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®