mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christoph Hellwig <hch@lst.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] TIOC* compat ioctl handling
Date: Thu, 3 Nov 2005 00:20:12 +1100	[thread overview]
Message-ID: <20051103002012.5e422ae5.sfr@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

Hi Christoph,

This patch (commit 9c0cbd54ce0397017a823484f9a8054ab369b8a2) removed the
COMPATIBLE_IOCTL bits for TIOCSTART and TIOCSTOP because they are
unimplemented.  The result is that the first 50 times you type ^C at a
bash prompt (on ppc64 at least) you get a nice message in your syslog (and
on your console):

ioctl32(bash:3527): Unknown cmd fd(2) cmd(2000746e){' '} arg(00000000) on /dev/pts/0

Because bash (on ppc64 at least) does a TIOCSTART ioctl when ^C is
pressed.  The ioctl always returned EINVAL but now we also get the log
message.  Should we put the COMPATIBLE_IOCTL bits back?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2005-11-02 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-02 13:20 Stephen Rothwell [this message]
2005-11-02 16:11 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2005-09-19 15:12 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051103002012.5e422ae5.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®