mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Zach Brown <zach.brown@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	hch@infradead.org, mark.fasheh@oracle.com
Subject: Re: [Patch] add AOP_TRUNCATED_PAGE, prepend AOP_ to WRITEPAGE_ACTIVATE
Date: Thu, 3 Nov 2005 12:45:36 +1100	[thread overview]
Message-ID: <20051103124536.0191bea6.akpm@osdl.org> (raw)
In-Reply-To: <43667913.4030401@oracle.com>

Zach Brown <zach.brown@oracle.com> wrote:
>
> readpage(), prepare_write(), and commit_write() callers are updated to
>  understand the special return code AOP_TRUNCATED_PAGE in the style of
>  writepage() and WRITEPAGE_ACTIVATE.  AOP_TRUNCATED_PAGE tells the caller that
>  the callee has unlocked the page and that the operation should be tried again
>  with a new page.  OCFS2 uses this to detect and work around a lock inversion in
>  its aop methods.  There should be no change in behaviour for methods that don't
>  return AOP_TRUNCATED_PAGE.
> 
>  WRITEPAGE_ACTIVATE is also prepended with AOP_ for consistency and they are
>  made enums so that kerneldoc can be used to document their semantics.

Looks sane to me.   Can you carry this in the ocfs2 tree?

  reply	other threads:[~2005-11-03  2:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-31 20:05 Zach Brown
2005-11-03  1:45 ` Andrew Morton [this message]
2005-11-03  7:43   ` Joel Becker
2005-11-03 16:53     ` Christoph Hellwig
2005-11-04  4:58       ` Andrew Morton
2005-11-04 18:31         ` Zach Brown
2005-11-04 18:37           ` Wim Coekaerts
2005-11-04 20:59           ` Christoph Hellwig
2005-11-09  8:06             ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051103124536.0191bea6.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.fasheh@oracle.com \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome