From: Andrew Morton <akpm@osdl.org>
To: Michael Krufky <mkrufky@m1k.net>
Cc: linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org
Subject: Re: [PATCH 05/37] dvb: add alternate stv0297-driver
Date: Thu, 3 Nov 2005 13:40:43 +1100 [thread overview]
Message-ID: <20051103134043.55fc2b26.akpm@osdl.org> (raw)
In-Reply-To: <43672375.1020603@m1k.net>
Michael Krufky <mkrufky@m1k.net> wrote:
>
> +#define abs64(x) (x) < 0 ? -(x) : (x);
Needs parentheses around the whole thing.
This should go into include/linus/kernel.h, after labs(), methinks.
> +static s64 div64(s64 dividend,s64 divisor)
hm. If we really need a 64-by-64 divide then it shouldn't be hidden in a dvb
driver, please. I bet we have a few in the tree already, actually.
So it'd be appreciated if someone could take a shot at generating a generic
version of this. It'll need to be inlined for 64-bit arches, out-of-line
for 32-bit.
It'll also need to be permanently wired into the kernel, alas. We cannot
tell at compile time whether it'll be needed :( EXPORT_SYMBOL() it.
prev parent reply other threads:[~2005-11-03 3:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 8:12 Michael Krufky
2005-11-03 2:40 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051103134043.55fc2b26.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@m1k.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome