From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Hugh Dickins <hugh@veritas.com>
Cc: Gleb Natapov <gleb@minantech.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Petr Vandrovec <vandrove@vc.cvut.cz>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Badari Pulavarty <pbadari@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Nick's core remove PageReserved broke vmware...
Date: Thu, 3 Nov 2005 17:14:21 +0200 [thread overview]
Message-ID: <20051103151421.GD31134@mellanox.co.il> (raw)
In-Reply-To: <Pine.LNX.4.61.0511031447080.23441@goblin.wat.veritas.com>
Quoting Hugh Dickins <hugh@veritas.com>:
> > All existing drivers that set VM_DONTCOPY also set VM_IO.
> > So lets just disable playing with these flags from madvise if VM_IO is set.
> > There's no reason I can see that the driver should have a say
> > on what the process does with its own (non-IO) memory.
> > Sounds good?
>
> You're then saying that a process cannot set VM_DONTCOPY on a VM_IO
> area to prevent the first child getting the area, but clear it after
> so the next child does get a copy of the area. I think it'd be wrong
> (surprising) to limit the functionality in that way.
Okay, I guess. I am just trying to avoid more VM_ flags.
Cant we get rid of the last requirement, then?
I dont see why the driver should have a say on what the process does with its
own memory.
> > By the way, as a separate issue, we still have a problem with DMA to pages
> > which are *needed* by the child process. What do you think about VM_COPY
> > (to do the old unix thing of actually copying the page instead of
> > setting the COW flag) and a matching madvise call to set/clear it?
>
> I don't much want to add another path into copy_pte_range, actually
> copying pages. If the process really wants DMA into such areas,
> then it should contain the code for the child to COW them itself?
>
> Hugh
How do you do that, say, for a stack page, or global data section?
--
MST
next prev parent reply other threads:[~2005-11-03 15:11 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 19:30 Petr Vandrovec
2005-11-02 0:34 ` Nick Piggin
2005-11-02 1:17 ` Petr Vandrovec
2005-11-02 2:09 ` Nick Piggin
2005-11-02 12:26 ` Hugh Dickins
2005-11-02 18:06 ` Petr Vandrovec
2005-11-02 21:04 ` Benjamin Herrenschmidt
2005-11-02 21:41 ` Hugh Dickins
2005-11-02 21:45 ` Benjamin Herrenschmidt
2005-11-02 22:02 ` Hugh Dickins
2005-11-02 22:22 ` Benjamin Herrenschmidt
2005-11-03 8:03 ` Gleb Natapov
2005-11-03 13:32 ` Hugh Dickins
2005-11-03 13:55 ` Gleb Natapov
2005-11-03 21:21 ` Benjamin Herrenschmidt
2005-11-02 22:39 ` Petr Vandrovec
2005-11-03 8:12 ` Gleb Natapov
2005-11-03 14:11 ` Hugh Dickins
2005-11-03 14:22 ` Gleb Natapov
2005-11-03 14:37 ` Michael S. Tsirkin
2005-11-03 14:59 ` Hugh Dickins
2005-11-03 15:09 ` Gleb Natapov
2005-11-03 15:14 ` Michael S. Tsirkin [this message]
2005-11-03 15:37 ` Hugh Dickins
2005-11-03 15:53 ` Gleb Natapov
2005-11-03 15:56 ` Michael S. Tsirkin
2005-11-08 21:34 ` Michael S. Tsirkin
2005-11-10 12:35 ` Gleb Natapov
2005-11-10 12:48 ` Michael S. Tsirkin
2005-11-10 12:49 ` Gleb Natapov
2005-11-10 13:16 ` Michael S. Tsirkin
2005-11-10 13:16 ` Gleb Natapov
2005-11-10 13:21 ` Hugh Dickins
2005-11-10 13:26 ` Gleb Natapov
2005-11-10 13:15 ` Hugh Dickins
2005-11-10 13:10 ` Hugh Dickins
2005-11-10 13:37 ` Michael S. Tsirkin
2005-11-10 13:55 ` Hugh Dickins
2005-11-10 14:12 ` Michael S. Tsirkin
2005-11-14 12:25 ` Michael S. Tsirkin
2005-11-14 12:27 ` Gleb Natapov
2005-11-14 12:34 ` Michael S. Tsirkin
2005-11-14 12:40 ` Hugh Dickins
2005-11-14 14:57 ` Michael S. Tsirkin
2005-11-14 15:07 ` Gleb Natapov
2005-11-14 12:41 ` Gleb Natapov
2005-11-14 14:52 ` Michael S. Tsirkin
2005-11-14 15:00 ` Gleb Natapov
2005-11-14 20:23 ` Michael S. Tsirkin
2005-11-15 9:26 ` Gleb Natapov
2005-11-14 15:58 ` Hugh Dickins
2005-11-14 21:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051103151421.GD31134@mellanox.co.il \
--to=mst@mellanox.co.il \
--cc=benh@kernel.crashing.org \
--cc=gleb@minantech.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pbadari@us.ibm.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®