mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: macro@linux-mips.org
Cc: gregkh@suse.de, stern@rowland.harvard.edu, linux-kernel@vger.kernel.org
Subject: Re: post-2.6.14 USB change breaks sparc64 boot
Date: Fri, 04 Nov 2005 09:40:53 -0800 (PST)	[thread overview]
Message-ID: <20051104.094053.118921373.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.55.0511031738390.24109@blysk.ds.pg.gda.pl>

From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 3 Nov 2005 17:46:20 +0000 (GMT)

> On Thu, 3 Nov 2005, David S. Miller wrote:
> 
> > Perhaps pci_fixup_final would be a more appropriate time to run this
> > USB host controller fixup?  One downside to this is that such calls
> > would not be invoked for hot-plugged USB host controller devices.
> 
>  This might actually want to be split to disable legacy stuff as soon as
> possible to prevent a flood of interrupts, sending SMIs and what not else.  
> That just requires poking at the PCI config space.  Whatever's the rest
> could be done later.  I guess hot-plugged USB host controllers are not
> configured for legacy support, so the early bits should not matter for
> them.

Would anyone mind if I pushed to Linus the following fix, at
least for now?  Thanks.

diff-tree 834843a8562e6614768d8c8b8a23d94d98af7360 (from 06024f217d607369f0ee0071034ebb03071d5fb2)
Author: David S. Miller <davem@sunset.davemloft.net>
Date:   Fri Nov 4 09:38:18 2005 -0800

    [USB]: Make early handoff a final fixup instead of a header one.
    
    At header fixup time, it is not yet legal to ioremap() PCI
    device registers, yet that is what this quirk code needs to
    do.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index b1aa350..e46528c 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -316,4 +316,4 @@ static void __devinit quirk_usb_early_ha
 	else if (pdev->class == PCI_CLASS_SERIAL_USB_EHCI)
 		quirk_usb_disable_ehci(pdev);
 }
-DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, quirk_usb_early_handoff);
+DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, quirk_usb_early_handoff);

  parent reply	other threads:[~2005-11-04 17:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-03 17:33 David S. Miller
2005-11-03 17:46 ` Maciej W. Rozycki
2005-11-03 18:54   ` Alan Stern
2005-11-03 19:24     ` Maciej W. Rozycki
2005-11-03 19:46       ` Alan Stern
2005-11-04 17:40   ` David S. Miller [this message]
2005-11-04 17:49     ` Greg KH
2005-11-04 18:47       ` Alan Stern
2005-11-03 23:26 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051104.094053.118921373.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®