From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: davej@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] export ia64_max_cacheline_size
Date: Fri, 4 Nov 2005 14:55:34 -0800 [thread overview]
Message-ID: <20051104145534.17e913f2.akpm@osdl.org> (raw)
In-Reply-To: <20051104223441.GA16285@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
>
> On Fri, Nov 04, 2005 at 05:07:37PM -0500, Dave Jones wrote:
> > on ia64, dma_get_cache_alignment() needs ia64_max_cacheline_size,
> > which isn't exported. This breaks modular compilation of the b44
> > network driver (and possibly others).
>
> Can we please move dma_get_cache_alignment() out of line instead?
It's a single statement! It wants to be inlined.
> Always export sane APIs instead of random internals.
The exported API is dma_get_cache_alignment(). For internal implementation
reasons we need to export an ia64 symbol to modules to support it. That
kinda sucks, but I don't think that we need to compromise kernel size and
performance because of it.
next prev parent reply other threads:[~2005-11-04 22:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 22:07 Dave Jones
2005-11-04 22:34 ` Christoph Hellwig
2005-11-04 22:55 ` Andrew Morton [this message]
2005-11-04 23:52 ` Christoph Hellwig
2005-11-05 0:05 ` Andrew Morton
2005-11-05 4:35 ` John W. Linville
2005-11-05 4:37 ` [patch 2.6.14] ia64: re-implement dma_get_cache_alignment to avoid EXPORT_SYMBOL John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104145534.17e913f2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®