From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@ucw.cz>, David Woodhouse <dwmw2@infradead.org>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk,
dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [patch] collie: fixup mtd a bit
Date: Fri, 4 Nov 2005 15:12:39 -0800 [thread overview]
Message-ID: <20051104151239.4a39a529.akpm@osdl.org> (raw)
In-Reply-To: <20051101233320.GA31263@elf.ucw.cz>
Pavel Machek <pavel@ucw.cz> wrote:
>
> Get collie mtd support closer to working/clean state.
>
This patch throws a screen-sized reject due to conflicting changes in
dwmw2's MTD tree. I'd suggest that you rework the patch and send it in via
David (who needs to get a wiggle on if he wants his stuff in 2.6.15).
> default:
> - printk("Waiting for chip\n");
> -
> set_current_state(TASK_INTERRUPTIBLE);
> add_wait_queue(&chip->wq, &wait);
>
> spin_unlock_bh(chip->mutex);
>
> - schedule();
> + udelay(1);
> +
> + set_current_state(TASK_RUNNING);
> remove_wait_queue(&chip->wq, &wait);
>
> if(signal_pending(current))
> @@ -255,7 +256,7 @@ retry:
If you're going to do this then you should remove all that now-pointless
waitqueue and task-state handling.
prev parent reply other threads:[~2005-11-04 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 23:33 Pavel Machek
2005-11-04 23:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104151239.4a39a529.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®