From: Ashok Raj <ashok.raj@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Ashok Raj <ashok.raj@intel.com>,
rjw@sisk.pl, linux-kernel@vger.kernel.org,
davej@codemonkey.org.uk, mingo@elte.hu, linux@brodo.de,
venkatesh.pallipadi@intel.com
Subject: Re: 2.6.14-git3: scheduling while atomic from cpufreq on Athlon64
Date: Fri, 4 Nov 2005 16:00:01 -0800 [thread overview]
Message-ID: <20051104160000.A16485@unix-os.sc.intel.com> (raw)
In-Reply-To: <20051104143035.120fe158.akpm@osdl.org>; from akpm@osdl.org on Fri, Nov 04, 2005 at 02:30:35PM -0800
On Fri, Nov 04, 2005 at 02:30:35PM -0800, Andrew Morton wrote:
> Ashok Raj <ashok.raj@intel.com> wrote:
> >
> >
> > ...
> >
> > seems ugly, but i dont find a better looking cure...
> >
>
> Could you take another look, please? It really is pretty gross.
Agree, frankly i didnt like this either, but the calls there were so
nested that i tried doing multiple ways and it appeared they need
to be broken down so much to do this a little cleanly.
i did put a real ugly comment earlier, but i must have removed it in the next
respin.
I was hoping to do just make the dirs appear/disapper (so i get the
behaviour i need) and let people more familier with the code go fix it.
>
> And the second rule of pretty-gross code is to clearly comment it - draw
>
pretty-gross.... humbly saying that is :-) i will attempt to look at it
again.
cpufreq folks... if you have better ideas brewing to make this work
in a pretty-clean way.... many thanks!
Cheers,
ashok
next prev parent reply other threads:[~2005-11-05 0:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 15:06 Rafael J. Wysocki
2005-10-31 19:34 ` Andrew Morton
2005-10-31 19:45 ` Rafael J. Wysocki
2005-10-31 20:42 ` Ashok Raj
2005-11-01 19:07 ` Rafael J. Wysocki
2005-11-01 19:14 ` Ashok Raj
2005-11-01 19:44 ` Rafael J. Wysocki
2005-11-01 20:00 ` Ashok Raj
2005-11-01 19:49 ` Lee Revell
2005-11-04 22:30 ` Andrew Morton
2005-11-05 0:00 ` Ashok Raj [this message]
2005-11-05 23:19 ` Ashok Raj
2005-11-05 23:33 ` Andrew Morton
2005-11-05 23:54 ` Ashok Raj
2005-11-06 0:06 ` Andrew Morton
2005-11-06 4:32 ` Keith Owens
2005-10-31 21:42 ` [patch] preempt-trace.patch Ingo Molnar
2005-11-01 19:08 ` Rafael J. Wysocki
2005-11-02 6:27 ` 2.6.14-git3: scheduling while atomic from cpufreq on Athlon64 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104160000.A16485@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=akpm@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome