From: Andrew Morton <akpm@osdl.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] kconfig: fix restart for choice symbols
Date: Fri, 4 Nov 2005 22:05:47 -0800 [thread overview]
Message-ID: <20051104220547.2e5686dc.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0511031606240.2497@scrub.home>
Roman Zippel <zippel@linux-m68k.org> wrote:
>
>
> The restart check whether new symbols became visible, didn't always work
> for choice symbols.
>
> ...
> --- linux-2.6.orig/scripts/kconfig/conf.c 2005-11-03 13:19:34.000000000 +0100
> +++ linux-2.6/scripts/kconfig/conf.c 2005-11-03 13:22:59.000000000 +0100
> @@ -468,7 +468,8 @@ static void check_conf(struct menu *menu
>
> sym = menu->sym;
> if (sym) {
> - if (sym_is_changable(sym) && !sym_has_value(sym)) {
> + if ((sym_is_changable(sym) || sym_is_choice(sym)) &&
> + !sym_has_value(sym)) {
> if (!conf_cnt++)
> printf(_("*\n* Restart config...\n*\n"));
> rootEntry = menu_get_parent_menu(menu);
This makes `make allmodconfig' go into an infinite loop.
USB Gadget Drivers
Gadget Zero (DEVELOPMENT) (USB_ZERO) [M/n/?] m
Ethernet Gadget (with CDC Ethernet support) (USB_ETH) [M/n/?] m
RNDIS support (EXPERIMENTAL) (USB_ETH_RNDIS) [Y/n/?] y
Gadget Filesystem (EXPERIMENTAL) (USB_GADGETFS) [M/n/?] m
File-backed Storage Gadget (USB_FILE_STORAGE) [M/n/?] m
File-backed Storage Gadget testing version (USB_FILE_STORAGE_TEST) [Y/n/?] y
Serial Gadget (with CDC ACM support) (USB_G_SERIAL) [M/n/?] m
*
* Restart config...
*
*
* USB Gadget Support
*
Support for USB Gadgets (USB_GADGET) [M/n/y/?] m
Debugging information files (USB_GADGET_DEBUG_FILES) [Y/n/?] y
USB Peripheral Controller
> 1. NetChip 2280 (USB_GADGET_NET2280)
2. Toshiba TC86C001 'Goku-S' (USB_GADGET_GOKU) (NEW)
3. Dummy HCD (DEVELOPMENT) (USB_GADGET_DUMMY_HCD) (NEW)
choice[1-3?]: 1
USB Gadget Drivers
Gadget Zero (DEVELOPMENT) (USB_ZERO) [M/n/?] m
Ethernet Gadget (with CDC Ethernet support) (USB_ETH) [M/n/?] m
RNDIS support (EXPERIMENTAL) (USB_ETH_RNDIS) [Y/n/?] y
Gadget Filesystem (EXPERIMENTAL) (USB_GADGETFS) [M/n/?] m
File-backed Storage Gadget (USB_FILE_STORAGE) [M/n/?] m
File-backed Storage Gadget testing version (USB_FILE_STORAGE_TEST) [Y/n/?] y
Serial Gadget (with CDC ACM support) (USB_G_SERIAL) [M/n/?] m
*
* Restart config...
*
*
* USB Gadget Support
*
Support for USB Gadgets (USB_GADGET) [M/n/y/?] m
Debugging information files (USB_GADGET_DEBUG_FILES) [Y/n/?] y
USB Peripheral Controller
> 1. NetChip 2280 (USB_GADGET_NET2280)
2. Toshiba TC86C001 'Goku-S' (USB_GADGET_GOKU) (NEW)
3. Dummy HCD (DEVELOPMENT) (USB_GADGET_DUMMY_HCD) (NEW)
choice[1-3?]: 1
USB Gadget Drivers
Gadget Zero (DEVELOPMENT) (USB_ZERO) [M/n/?] m
Ethernet Gadget (with CDC Ethernet support) (USB_ETH) [M/n/?] m
RNDIS support (EXPERIMENTAL) (USB_ETH_RNDIS) [Y/n/?] y
Gadget Filesystem (EXPERIMENTAL) (USB_GADGETFS) [M/n/?] m
File-backed Storage Gadget (USB_FILE_STORAGE) [M/n/?] m
File-backed Storage Gadget testing version (USB_FILE_STORAGE_TEST) [Y/n/?] y
Serial Gadget (with CDC ACM support) (USB_G_SERIAL) [M/n/?] m
*
* Restart config...
*
*
* USB Gadget Support
*
Support for USB Gadgets (USB_GADGET) [M/n/y/?] m
Debugging information files (USB_GADGET_DEBUG_FILES) [Y/n/?] y
USB Peripheral Controller
> 1. NetChip 2280 (USB_GADGET_NET2280)
2. Toshiba TC86C001 'Goku-S' (USB_GADGET_GOKU) (NEW)
3. Dummy HCD (DEVELOPMENT) (USB_GADGET_DUMMY_HCD) (NEW)
choice[1-3?]: 1
USB Gadget Drivers
Gadget Zero (DEVELOPMENT) (USB_ZERO) [M/n/?] m
Ethernet Gadget (with CDC Ethernet support) (USB_ETH) [M/n/?] m
RNDIS support (EXPERIMENTAL) (USB_ETH_RNDIS) [Y/n/?] y
Gadget Filesystem (EXPERIMENTAL) (USB_GADGETFS) [M/n/?] m
File-backed Storage Gadget (USB_FILE_STORAGE) [M/n/?] m
File-backed Storage Gadget testing version (USB_FILE_STORAGE_TEST) [Y/n/?] y
Serial Gadget (with CDC ACM support) (USB_G_SERIAL) [M/n/?] m
next prev parent reply other threads:[~2005-11-05 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-03 15:06 Roman Zippel
2005-11-05 6:05 ` Andrew Morton [this message]
2005-11-07 11:53 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104220547.2e5686dc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®