mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Jon Masters <jonathan@jonmasters.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: fix-readonly-policy-use-and-floppy-ro-rw-status
Date: Sat, 5 Nov 2005 13:41:22 -0500	[thread overview]
Message-ID: <20051105184122.GA30451@havoc.gtf.org> (raw)
In-Reply-To: <20051105182728.GB27767@apogee.jonmasters.org>

On Sat, Nov 05, 2005 at 06:27:28PM +0000, Jon Masters wrote:
> [PATCH]: This modifies the gendisk and hd_struct structs to replace "policy"
> with "readonly" (as that's the only use for this field). It also introduces a
> new function disk_read_only, which behaves like the corresponding device
> functions do. I've also replaced direct usage of the old policy fields with
> calls to the appropriate function.
> 
> Signed-off-by: Jon Masters <jcm@jonmasters.org>

Please fix your patch format per http://linux.yyz.us/patch-format.html

Notably:

- Using "[PATCH] " not "PATCH: " in subject line.

- Don't repeat "[PATCH]" in text body, this must be manually edited out.

- This is English, not dashish.  Remove the dashes from the
  one-line description found in the subject line.  These must be
  hand-edited out, too.


  parent reply	other threads:[~2005-11-05 18:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-05 18:27 Jon Masters
2005-11-05 18:33 ` Andrew Morton
2005-11-05 18:40   ` Jon Masters
2005-11-05 18:44     ` Al Viro
2005-11-05 18:51       ` Jon Masters
2005-11-05 19:01         ` Al Viro
2005-11-05 19:39           ` Jon Masters
2005-11-05 18:42   ` Al Viro
2005-11-05 18:48     ` Jon Masters
2005-11-05 18:41 ` Jeff Garzik [this message]
2005-11-06 10:59   ` Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051105184122.GA30451@havoc.gtf.org \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®