From: Pavel Machek <pavel@suse.cz>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: swsusp not able to stop tasks
Date: Sun, 6 Nov 2005 22:34:11 +0100 [thread overview]
Message-ID: <20051106213411.GJ29901@elf.ucw.cz> (raw)
In-Reply-To: <4369CEA9.4030008@drzeus.cx>
Hi!
> >>>What is this kauditd? Try turning auditing off in kernel config, and
> >>>it should go away. If it does, add try_to_freeze() at place where
> >>>sleep is possible into kauditd...
> >>>
> >>That it did. And the machine suspends fine with audit removed. I'll have
> >>a look at inserting those try_to_freeze().
> >>
> >
> >Good.
> The following did the trick:
Looks good to me. I'm not sure, but whitespace looks slightly wrong to
me. Can you write changelog, sign it off, add my acked-by, and send it
to akpm?
Pavel
> diff --git a/kernel/audit.c b/kernel/audit.c
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -291,8 +291,10 @@ int kauditd_thread(void *dummy)
> set_current_state(TASK_INTERRUPTIBLE);
> add_wait_queue(&kauditd_wait, &wait);
>
> - if (!skb_queue_len(&audit_skb_queue))
> + if (!skb_queue_len(&audit_skb_queue)) {
> + try_to_freeze();
> schedule();
> + }
>
> __set_current_state(TASK_RUNNING);
> remove_wait_queue(&kauditd_wait, &wait);
--
Thanks, Sharp!
prev parent reply other threads:[~2005-11-06 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 13:22 Pierre Ossman
2005-11-02 13:38 ` Pavel Machek
2005-11-02 15:29 ` Pierre Ossman
2005-11-02 21:03 ` Pavel Machek
2005-11-03 8:47 ` Pierre Ossman
2005-11-06 21:34 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051106213411.GJ29901@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®