Re: [Alsa-devel] Re: + v4l-720-alsa-support-for-saa7134-that-should-work-fix.patch added to -mm tree

[Andrew Morton <akpm@osdl.org>]

Takashi Iwai <tiwai@suse.de> wrote:
>
> > OK, a brief review:
>  > 
>  >  - Why couldn't you use ALSA's DMA API?
> 
>  This is OK, IMO.  Basically, it's up to the driver.
> 
> 
>  >  - The DMA must be stopped and started in the trigger callback, not the
>  > prepare callback.
>  > 
>  >  - If this device lacks a volume control alsa-lib can emulate it in
>  > software, just create a proper /usr/share/alsa/cards/your_card.conf
>  > file.
>  > 
>  >  - By ALSA convention the acceptable formats, sample rates, etc should
>  > be directly defined in the snd_pcm_hardware_t structure.
>  > 
>  >  - dev->oss needs to go.
> 
>  Agreed about the rest.

Thanks, guys.

Despite all that, I am inclined to merge this patch into 2.6.15.  Because
it's in the middle of a 192-patch series and we do need to get the v4l tree
synced up.

Mauro&co, if we do that, do you think the above points can be addressed
inside the next four weeks or so?