From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org,
William Lee Irwin III <wli@holomorphy.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] use ptrace_get_task_struct in various places
Date: Mon, 7 Nov 2005 22:11:49 -0800 [thread overview]
Message-ID: <20051107221149.08aa0820.akpm@osdl.org> (raw)
In-Reply-To: <20051108053049.GA9422@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
>
> The ptrace_get_task_struct() helper that I added as part of the ptrace
> consolidation is usefull in variety of places that currently opencode
> it. Switch them to the common helper.
If we're going to export ptrace_get_task_struct() to the world it would be
nice to document it too - things like returning zero and a NULL *childp is
a little obscure.
The change breaks ALLOW_INIT_TRACING in sparc32 and sparc64. I don't know
if that matters. If (presumably) not, there are cleanups left over.
In arch/ia64/ia32/sys_ia32.c this patch will cause PTRACE_TRACEME requests
to be handled by ptrace_request() rather than by sys_ptrace(), which is a
not-obviously-correct change.
Was the omission of arch/ia64/kernel/ptrace.c:sys_ptrace() deliberate?
next prev parent reply other threads:[~2005-11-08 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 5:30 Christoph Hellwig
2005-11-08 6:11 ` Andrew Morton [this message]
2005-11-08 16:51 ` David S. Miller
2005-11-10 23:27 ` Christoph Hellwig
2005-11-11 0:00 ` Andrew Morton
2005-11-11 8:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107221149.08aa0820.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®