From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MMC] wbsd pnp suspend
Date: Tue, 8 Nov 2005 02:06:21 -0500 [thread overview]
Message-ID: <200511080206.21831.dtor_core@ameritech.net> (raw)
In-Reply-To: <43704C3D.30602@drzeus.cx>
On Tuesday 08 November 2005 01:57, Pierre Ossman wrote:
> Andrew Morton wrote:
> > Pierre Ossman <drzeus@drzeus.cx> wrote:
> >> + if (host->config != 0)
> >> + {
> >> + if (!wbsd_chip_validate(host))
> >> + {
> >
> > Like:
> >
> > if (host->config != 0) {
> > if (!wbsd_chip_validate(host)) {
> >
> > please.
> >
>
> We had this discussion the last patch for this driver. It's horribly
> wrong when it comes to coding style so keeping patches in the same style
> as the rest of the driver is the lesser evil (IMHO).
>
Aside from unusual brace placement it does not look too bad. How about
running it through Lindent to fix it once and for all?
--
Dmitry
next prev parent reply other threads:[~2005-11-08 7:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 6:41 Pierre Ossman
2005-11-08 6:50 ` Andrew Morton
2005-11-08 6:57 ` Pierre Ossman
2005-11-08 7:06 ` Dmitry Torokhov [this message]
2005-11-08 8:45 ` Pierre Ossman
2006-01-07 23:02 Pierre Ossman
2006-01-08 14:23 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511080206.21831.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome