From: "David S. Miller" <davem@davemloft.net>
To: davej@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: fix sparse warning in horizon atm driver.
Date: Wed, 09 Nov 2005 13:07:13 -0800 (PST) [thread overview]
Message-ID: <20051109.130713.06900332.davem@davemloft.net> (raw)
In-Reply-To: <20051109055739.GA630@redhat.com>
From: Dave Jones <davej@redhat.com>
Date: Wed, 9 Nov 2005 00:57:39 -0500
> these vars get fed u32's, and are OR'd with u32's.
> Chances are they were meant to be u32's.
>
> I don't have hardware to test this, but I can't fathom
> why a u16 would be used here.
>
> drivers/atm/horizon.c:1564:12: warning: cast truncates bits from constant value (40000000 becomes 0)
Hmmm... I would merge this directly, but I'd like Chas Williams
(the ATM maintainer) to glance it over first. Can you forward
it to him (CC:'ing the linux-atm list, also mentioned in MAINTAINERS,
of course)? Thanks.
next prev parent reply other threads:[~2005-11-09 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 5:57 Dave Jones
2005-11-09 21:07 ` David S. Miller [this message]
2005-11-10 16:00 ` chas williams - CONTRACTOR
2005-11-10 20:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051109.130713.06900332.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®