From: Pavel Machek <pavel@ucw.cz>
To: Josh Boyer <jwboyer@gmail.com>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>,
dwmw2@infradead.org, Andrew Morton <akpm@osdl.org>
Subject: Re: latest mtd changes broke collie
Date: Thu, 10 Nov 2005 10:48:46 +0100 [thread overview]
Message-ID: <20051110094846.GB2021@elf.ucw.cz> (raw)
In-Reply-To: <625fc13d0511091619t135ec822t7f77aeb27e5db6f@mail.gmail.com>
Hi!
> > Latest mtd changes break collie...it now oopses during boot. This
> > reverts the bad patch.
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
> >
> <snip>
> > - for(i=0;i<100;i++){
> > - status = map_read32(map,adr);
> > - if((status & SR_READY)==SR_READY)
> > - break;
> > - udelay(1);
> > + status = map_read32(map,adr);
>
> I was just discussing with someone today how map_read32 no longer
> exists in the kernel... does this even compile for you?
>
> Somehow I think I'm missing something...
I had other changes in my tree. Only old_mtd+my_changes worked, but
new_mtd+my_changes broke, so I figured out diff between old_mtd and
new_mtd must be bad. Given that neither old_mtd compiled nor new_mtd
compiled...
Fixes to map_read32 are being prepared.
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2005-11-10 9:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 22:17 Pavel Machek
2005-11-10 0:19 ` Josh Boyer
2005-11-10 9:48 ` Pavel Machek [this message]
2005-11-10 2:59 ` Todd Poynor
2005-11-10 9:50 ` Pavel Machek
2005-11-10 10:02 ` David Woodhouse
2005-11-10 10:38 ` Pavel Machek
2005-11-10 10:51 ` David Woodhouse
2005-11-10 10:59 ` Pavel Machek
2005-11-10 11:11 ` David Woodhouse
2005-11-10 11:44 ` Pavel Machek
2005-11-10 12:07 ` Pavel Machek
2005-11-10 13:02 ` David Vrabel
2005-11-10 13:09 ` Pavel Machek
2005-11-10 17:41 ` Richard Purdie
2005-11-10 18:09 ` Richard Purdie
2005-11-10 22:06 ` Pavel Machek
2005-11-10 22:41 ` Pavel Machek
2005-11-10 23:58 ` Todd Poynor
2005-11-11 0:16 ` Pavel Machek
2005-11-11 7:01 ` Ian Campbell
2005-11-12 21:33 ` Pavel Machek
2005-11-13 10:35 ` Ian Campbell
2005-11-14 12:10 ` Pavel Machek
2005-11-13 19:40 ` Todd Poynor
2005-11-14 12:08 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051110094846.GB2021@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=jwboyer@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®