mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: Christoph Lameter <clameter@sgi.com>, lhms-devel@lists.sourceforge.net
Subject: [PATCH 7/8] Direct Migration V3: add_to_swap() with additional gfp_t parameter
Date: Fri, 11 Nov 2005 14:37:08 -0800 (PST)	[thread overview]
Message-ID: <20051111223708.21716.92798.sendpatchset@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20051111223632.21716.49021.sendpatchset@schroedinger.engr.sgi.com>

Add gfp_mask to add_to_swap

The migration code calls the function with GFP_KERNEL
while the swap code calls it with GFP_ATOMIC, because
the migration code can ask the swap code to free some pages
when we're in a low memory situation.

Signed-off-by: Hirokazu Takahashi <taka@valinux.co.jp>
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.14-mm2/include/linux/swap.h
===================================================================
--- linux-2.6.14-mm2.orig/include/linux/swap.h	2005-11-11 14:07:02.000000000 -0800
+++ linux-2.6.14-mm2/include/linux/swap.h	2005-11-11 14:07:04.000000000 -0800
@@ -242,7 +242,7 @@ extern int rw_swap_page_sync(int, swp_en
 extern struct address_space swapper_space;
 #define total_swapcache_pages  swapper_space.nrpages
 extern void show_swap_cache_info(void);
-extern int add_to_swap(struct page *);
+extern int add_to_swap(struct page *, gfp_t);
 extern void __delete_from_swap_cache(struct page *);
 extern void delete_from_swap_cache(struct page *);
 extern int move_to_swap_cache(struct page *, swp_entry_t);
Index: linux-2.6.14-mm2/mm/swap_state.c
===================================================================
--- linux-2.6.14-mm2.orig/mm/swap_state.c	2005-11-11 14:07:02.000000000 -0800
+++ linux-2.6.14-mm2/mm/swap_state.c	2005-11-11 14:07:04.000000000 -0800
@@ -143,7 +143,7 @@ void __delete_from_swap_cache(struct pag
  * Allocate swap space for the page and add the page to the
  * swap cache.  Caller needs to hold the page lock. 
  */
-int add_to_swap(struct page * page)
+int add_to_swap(struct page * page, gfp_t gfp_mask)
 {
 	swp_entry_t entry;
 	int err;
@@ -171,7 +171,7 @@ int add_to_swap(struct page * page)
 		 * Add it to the swap cache and mark it dirty
 		 */
 		err = __add_to_swap_cache(page, entry,
-				GFP_ATOMIC|__GFP_NOMEMALLOC|__GFP_NOWARN);
+				gfp_mask|__GFP_NOMEMALLOC|__GFP_NOWARN);
 
 		switch (err) {
 		case 0:				/* Success */
Index: linux-2.6.14-mm2/mm/vmscan.c
===================================================================
--- linux-2.6.14-mm2.orig/mm/vmscan.c	2005-11-11 14:07:02.000000000 -0800
+++ linux-2.6.14-mm2/mm/vmscan.c	2005-11-11 14:07:04.000000000 -0800
@@ -456,7 +456,7 @@ static int shrink_list(struct list_head 
 		if (PageAnon(page) && !PageSwapCache(page)) {
 			if (!sc->may_swap)
 				goto keep_locked;
-			if (!add_to_swap(page))
+			if (!add_to_swap(page, GFP_ATOMIC))
 				goto activate_locked;
 		}
 #endif /* CONFIG_SWAP */
@@ -911,7 +911,7 @@ redo:
 		 * preserved.
 		 */
 		if (PageAnon(page) && !PageSwapCache(page)) {
-			if (!add_to_swap(page)) {
+			if (!add_to_swap(page, GFP_KERNEL)) {
 				unlock_page(page);
 				list_move(&page->lru, failed);
 				nr_failed++;

  parent reply	other threads:[~2005-11-11 22:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-11 22:36 [PATCH 0/8] Direct Migration V3: Overview Christoph Lameter
2005-11-11 22:36 ` [PATCH 1/8] Direct Migration V3: Swap migration patchset fixes Christoph Lameter
2005-11-11 22:36 ` [PATCH 2/8] Direct Migration V3: PageSwapCache checks Christoph Lameter
2005-11-11 22:36 ` [PATCH 3/8] Direct Migration V3: migrate_pages() extension Christoph Lameter
2005-11-11 22:36 ` [PATCH 4/8] Direct Migration V3: remove_from_swap() to remove swap ptes Christoph Lameter
2005-11-11 22:36 ` [PATCH 5/8] Direct Migration V3: upgrade MPOL_MF_MOVE and sys_migrate_pages() Christoph Lameter
2005-11-11 22:37 ` [PATCH 6/8] Direct Migration V3: Avoid writeback / page_migrate() method Christoph Lameter
2005-11-11 22:37 ` Christoph Lameter [this message]
2005-11-11 22:37 ` [PATCH 8/8] Direct Migration V3: SWAP_REFERENCE for try_to_unmap() Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051111223708.21716.92798.sendpatchset@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=lhms-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®