From: Andrew Morton <akpm@osdl.org>
To: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: selhorst@crypto.rub.de, linux-kernel@vger.kernel.org,
castet.matthieu@free.fr
Subject: Re: [PATCH] TPM: cleanups
Date: Sat, 12 Nov 2005 13:48:44 -0800 [thread overview]
Message-ID: <20051112134844.7f177e07.akpm@osdl.org> (raw)
In-Reply-To: <1131750533.5048.36.camel@localhost.localdomain>
Kylene Jo Hall <kjhall@us.ibm.com> wrote:
>
> + schedule_work(&chip->work);
> +}
> +
> +static void timeout_work(void * ptr)
> +{
> + struct tpm_chip *chip = (struct tpm_chip*) ptr;
> +
I cannot see where the tpm driver stops that timer which it has running on
device close or on module unload.
Wherever it is, we'll now also need a flush_scheduled_work() to avoid a race
wherein the work handler is still executing while the module gets
unloaded.
next prev parent reply other threads:[~2005-11-12 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 17:11 [PATCH] Infineon TPM: move infineon driver off pci_dev Marcel Selhorst
2005-10-26 17:23 ` Kylene Jo Hall
2005-10-26 17:41 ` matthieu castet
2005-10-26 19:53 ` Marcel Selhorst
2005-10-27 11:22 ` Marcel Selhorst
2005-10-27 14:07 ` Kylene Jo Hall
2005-10-27 21:55 ` Andrew Morton
2005-10-27 22:03 ` Roland Dreier
2005-10-27 22:26 ` Andrew Morton
2005-10-28 14:22 ` Kylene Jo Hall
2005-11-11 20:11 ` [PATCH] TPM: cleanups Kylene Jo Hall
2005-11-11 23:08 ` Kylene Jo Hall
2005-11-12 21:48 ` Andrew Morton [this message]
2005-11-16 22:48 ` Kylene Jo Hall
2005-10-27 21:33 ` [PATCH] Infineon TPM: move infineon driver off pci_dev Andrew Morton
2005-10-28 5:23 ` Marcel Selhorst
2005-10-27 21:42 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051112134844.7f177e07.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=castet.matthieu@free.fr \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=selhorst@crypto.rub.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome