mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Bernhard Rosenkraenzer <bero@arklinux.org>, linux-kernel@vger.kernel.org
Subject: Re: [partial patch] 2.6.14-mm2 bugs and fixes
Date: Sun, 13 Nov 2005 11:04:21 -0800	[thread overview]
Message-ID: <20051113190421.GA1520@kroah.com> (raw)
In-Reply-To: <20051113105552.68705c3c.akpm@osdl.org>

On Sun, Nov 13, 2005 at 10:55:52AM -0800, Andrew Morton wrote:
> Bernhard Rosenkraenzer <bero@arklinux.org> wrote:
> > drivers/usb/core/message.c no longer exports usb_get_string, this
> > breaks some external drivers (probably most notably ndiswrapper) --
> > attached patch #2 reverts this.
> 
> Agree.  We shouldn't be ripping out exported symbols with zero notice like
> this.  We have a process for doing this.

I had no idea no one else used this symbol, as nothing in-kernel does,
sorry.  Care to tell me why you need this function?  A USB driver should
not use it, but rather use the already-cached strings the USB core
provides for you.

thanks,

greg k-h

  reply	other threads:[~2005-11-13 19:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200511131441.18443.bero@arklinux.org>
2005-11-13 18:55 ` Andrew Morton
2005-11-13 19:04   ` Greg KH [this message]
2005-11-13 18:58 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051113190421.GA1520@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=bero@arklinux.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®