Re: [PATCH 2 of 2] tpm: updates for new hardware

[Bjorn Helgaas <bjorn.helgaas@hp.com>]

On Friday 11 November 2005 1:06 pm, Kylene Jo Hall wrote:
> +#ifdef CONFIG_PPC64
> +#define atmel_getb(chip, offset) readb(chip->vendor->iobase + offset);
> +#define atmel_putb(val, chip, offset) writeb(val, chip->vendor->iobase + offset)
> ...
> +#else
> +#define atmel_getb(chip, offset) inb(chip->vendor->base + offset)
> +#define atmel_putb(val, chip, offset) outb(val, chip->vendor->base + offset)

Why don't you use ioread8() instead of defining atmel_getb()?

You'd still need something PPC64-specific to initialize the iomem cookie,
but the accessors would go away.

Unfortunately, ioread8() and associated interfaces aren't mentioned
under Documentation/, but there are some hints in lib/iomap.c.