From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: yanzheng@21cn.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)
Date: Tue, 15 Nov 2005 10:22:37 +0900 (JST) [thread overview]
Message-ID: <20051115.102237.101993116.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <43786A16.9070100@21cn.com>
In article <43786A16.9070100@21cn.com> (at Mon, 14 Nov 2005 18:42:30 +0800), Yan Zheng <yanzheng@21cn.com> says:
> The "score.rule++" doesn't make any sense for me.
> According to codes above, I think it should be "hiscore.rule++;" .
Oops, you're right.
> Signed-off-by: Yan Zheng<yanzheng@21cn.com>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> /* Rule 8: Use longest matching prefix */
> - if (hiscore.rule < 8)
> + if (hiscore.rule < 8) {
> hiscore.matchlen = ipv6_addr_diff(&ifa_result->addr, daddr);
> - score.rule++;
> + hiscore.rule++;
> + }
> score.matchlen = ipv6_addr_diff(&ifa->addr, daddr);
> if (score.matchlen > hiscore.matchlen) {
> score.rule = 8;
>
--
YOSHIFUJI Hideaki @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
next prev parent reply other threads:[~2005-11-15 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 10:42 Yan Zheng
2005-11-15 1:22 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2005-11-15 5:42 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051115.102237.101993116.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®