From: Christoph Hellwig <hch@infradead.org>
To: Paul Mackerras <paulus@samba.org>
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org,
Michael Neuling <mikey@neuling.org>
Subject: Re: [PATCH] Allow arch to veto PC speaker beeper initialization
Date: Tue, 15 Nov 2005 09:08:13 +0000 [thread overview]
Message-ID: <20051115090813.GB22160@infradead.org> (raw)
In-Reply-To: <17273.16792.850639.195427@cargo.ozlabs.ibm.com>
On Tue, Nov 15, 2005 at 01:02:00PM +1100, Paul Mackerras wrote:
> From: Michael Neuling <mikey@neuling.org>
>
> This patch provides an arch hook in the PC speaker beeper driver which
> gives the arch code an opportunity to determine whether the machine
> has an i8253 timer or not. If it doesn't we don't want the driver to
> go poking at the i8253's ports; there might be nothing there or there
> might be something else there which would be upset by being poked at.
>
> We want to be able to build ppc64 kernels which work both on machines
> that have an i8253 equivalent (e.g. some pSeries) and on machines that
> don't (e.g. G5 powermacs), which is why we don't just remove it from
> the config.
Wrong way around. The architecture should provide a way to find it, not
to veto it. It should probably use the plattform_device infrastructure.
prev parent reply other threads:[~2005-11-15 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-15 2:02 Paul Mackerras
2005-11-15 3:55 ` Andrew Morton
2005-11-15 4:00 ` Paul Mackerras
2005-11-15 9:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051115090813.GB22160@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®