From: "David S. Miller" <davem@davemloft.net>
To: akpm@osdl.org
Cc: jordan.crouse@amd.com, linux-kernel@vger.kernel.org
Subject: Re: PATCH: Fix poor pointer math in devinet_sysctl_register
Date: Wed, 16 Nov 2005 23:13:37 -0800 (PST) [thread overview]
Message-ID: <20051116.231337.113983448.davem@davemloft.net> (raw)
In-Reply-To: <20051116221412.7ecea148.akpm@osdl.org>
From: Andrew Morton <akpm@osdl.org>
Date: Wed, 16 Nov 2005 22:14:12 -0800
> "Jordan Crouse" <jordan.crouse@amd.com> wrote:
> > @@ -1454,7 +1454,7 @@ static void devinet_sysctl_register(stru
> > return;
> > memcpy(t, &devinet_sysctl, sizeof(*t));
> > for (i = 0; i < ARRAY_SIZE(t->devinet_vars) - 1; i++) {
> > - t->devinet_vars[i].data += (char *)p - (char *)&ipv4_devconf;
> > + t->devinet_vars[i].data += (int)((char *)p - (char *)&ipv4_devconf);
>
> Confused. These appear to be equivalent (on 32-bit CPUs, anyway).
Indeed, please describe the exact failure case when posting
such patches.
next prev parent reply other threads:[~2005-11-17 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 23:23 Jordan Crouse
2005-11-17 6:14 ` Andrew Morton
2005-11-17 7:13 ` David S. Miller [this message]
2005-11-17 10:53 ` Mikael Pettersson
2005-11-17 15:04 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051116.231337.113983448.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome