From: "Mark A. Greer" <mgreer@mvista.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrey Volkov <avolkov@varma-el.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
"Mark A. Greer" <mgreer@mvista.com>
Subject: Re: [PATCH 1/1] Added support of ST m41t85 rtc chip
Date: Tue, 15 Nov 2005 19:57:14 -0700 [thread overview]
Message-ID: <20051116025714.GK5546@mag.az.mvista.com> (raw)
In-Reply-To: <20051115215226.4e6494e0.khali@linux-fr.org>
Hi Jean,
On Tue, Nov 15, 2005 at 09:52:26PM +0100, Jean Delvare wrote:
<snip>
> First, a question. Can't you merge the M41T85 support into the m41t00
> driver?
>
> Mark, care to comment on that possibility, and/or on the code itself?
Sure.
I wrestled with the ST website for the m41t85 datasheet but lost so I
I can only guess from the patch. The drivers do look very similar.
It looks like the m41t85 is basically a m41t00 with an alarm (watchdog
timer never used AFAICT). Also there are some differences in register
offsets and [maybe] some minor differences within the registers but
nothing that serious.
I think we can combine the two into an m41txx.c and pass the exact type
in via platform_data--that would be the correct mechanism, right?
The platform_data could also be used to seed the correct SQW freq and
eliminate all the Kconfig noise.
Comments?
As for Jean's and Andrew's comments about the driver, they seem valid
to me and should be addressed. In Andrey's defense, many of them are my
fault. Once there is a consensus on the merging m41t00 & m41t85
question, I'll try to get a fixed up patch within a couple weeks.
Mark
next prev parent reply other threads:[~2005-11-16 2:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 13:50 Andrey Volkov
2005-11-15 0:41 ` Andrew Morton
2005-11-15 21:24 ` Andrey Volkov
2005-11-15 20:52 ` Jean Delvare
2005-11-15 21:48 ` Andrey Volkov
2005-11-16 3:15 ` Mark A. Greer
2005-11-16 14:50 ` Andrey Volkov
2005-11-16 18:55 ` Andy Isaacson
2005-11-16 22:24 ` Mark A. Greer
2005-11-18 20:35 ` Mark A. Greer
2005-11-21 12:35 ` Andrey Volkov
2005-12-06 21:18 ` Mark A. Greer
2005-11-16 2:57 ` Mark A. Greer [this message]
2005-11-16 14:45 ` Andrey Volkov
2005-11-16 15:19 ` Jean Delvare
2005-11-16 16:43 ` Andrey Volkov
2005-11-16 21:36 ` Mark A. Greer
2005-11-17 9:20 ` Jean Delvare
2005-11-16 21:24 ` Mark A. Greer
2005-12-19 21:03 ` [RFC] i2c: Combined ST m41txx i2c rtc chip driver (was: [PATCH 1/1] Added support of ST m41t85 rtc chip) Mark A. Greer
2005-12-19 21:06 ` Mark A. Greer
2005-12-20 10:05 ` [RFC] i2c: Combined ST m41txx i2c rtc chip driver Andrey Volkov
2005-12-21 21:25 ` Mark A. Greer
[not found] ` <20060111000912.GA11471@mag.az.mvista.com>
[not found] ` <43C4D275.2070505@varma-el.com>
[not found] ` <20060111161954.GB6405@mag.az.mvista.com>
2006-01-11 19:03 ` Andrey Volkov
2006-01-18 22:06 ` Mark A. Greer
2006-01-19 7:25 ` Jean Delvare
2006-01-26 2:01 ` Mark A. Greer
2006-01-26 20:50 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051116025714.GK5546@mag.az.mvista.com \
--to=mgreer@mvista.com \
--cc=avolkov@varma-el.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®