From: Christoph Hellwig <hch@infradead.org>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Simon.Derr@bull.net,
steiner@sgi.com
Subject: Re: [PATCH] cpuset export symbols gpl
Date: Wed, 16 Nov 2005 08:16:27 +0000 [thread overview]
Message-ID: <20051116081627.GA20555@infradead.org> (raw)
In-Reply-To: <20051115180336.11139847.pj@sgi.com>
On Tue, Nov 15, 2005 at 06:03:36PM -0800, Paul Jackson wrote:
> Andrew wrote (of exporting cpuset symbols)
> > We normally would do this when such modules are merged. Do tell us more..
>
> It was an oversight not to do this when cpusets went in last year,
> but we didn't notice, as the loadable module we cared about had a
> hack in place from earlier development that avoided needing this.
>
> In cleaning this up, we realized that the module needed to access
> task->cpuset->cpus_allowed, and that the correct (and safe) way to
> do this, via cpuset_cpus_allowed(), was not available to the module.
>
> The other 4 exports I added on general principles, but don't have
> any pressing need for. The one I need is cpuset_cpus_allowed().
>
> The loadable module in question we call 'dplace', and is used to
> provide fancier cpuset-relative task placement by manipulating
> task->cpus_allowed at exec.
Again, where is the module. Please submit the change to export the
symbols in the same patch series as that module. And honestly I don't
think it'll survive review when it's poking that deeply into cpuset
internals, but we'll see how to do it properly once it's sent here.
next prev parent reply other threads:[~2005-11-16 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 1:22 Paul Jackson
2005-11-16 1:39 ` Andrew Morton
2005-11-16 2:03 ` Paul Jackson
2005-11-16 8:16 ` Christoph Hellwig [this message]
2005-11-16 14:33 ` Robin Holt
2005-11-17 1:04 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051116081627.GA20555@infradead.org \
--to=hch@infradead.org \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome