From: "David S. Miller" <davem@davemloft.net>
To: davej@redhat.com
Cc: akpm@osdl.org, bunk@stusta.de, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
Date: Thu, 17 Nov 2005 19:42:39 -0800 (PST) [thread overview]
Message-ID: <20051117.194239.37311109.davem@davemloft.net> (raw)
In-Reply-To: <20051118031751.GA2773@redhat.com>
From: Dave Jones <davej@redhat.com>
Date: Thu, 17 Nov 2005 22:17:51 -0500
> On Thu, Nov 17, 2005 at 06:55:29PM -0800, Andrew Morton wrote:
>
> > > IMHO the warnings are the best solution for getting a vast amount fixed,
> > > and then it's time to think about the rest.
> >
> > But the warnings don't *work*. I'm *still* staring at stupid pm_register
> > and intermodule_foo warnings. How long has that been?
>
> Too long. I think the mtd stuff won't ever get fixed until after that
> function gets removed.
That's unfortunate considering we did cure the DRM cases :-)
My only thought is that virt_to_bus() and friends are a special case
because they mean compilation failure on most non-x86 platforms.
And frankly, __deprecated serves a different purpose as far as I'm
concerned. It let's people working on stuff outside the tree know
that "oops you shouldn't be using that interface".
The deprecated warnings are so easy to filter out, so I don't think
noise is a good argument. I see them all the time too.
The whole DMA API we have today was added 4+ years ago specifically
to get rid of virt_to_bus() and friends. It's been mostly successful,
but one last nudge like this deprecation marking might help get us over
the edge and finally delete the thing for good. :-)
Anyways, my 2cents.
next prev parent reply other threads:[~2005-11-18 3:43 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 1:40 Adrian Bunk
2005-11-18 1:50 ` Andrew Morton
2005-11-18 2:06 ` Adrian Bunk
2005-11-18 2:20 ` Andrew Morton
2005-11-18 2:44 ` Adrian Bunk
2005-11-18 2:55 ` Andrew Morton
2005-11-18 3:17 ` Dave Jones
2005-11-18 3:37 ` [2.6 patch] build kernel/intermodule.c only when required Adrian Bunk
2005-11-18 3:42 ` David S. Miller [this message]
2005-11-18 4:03 ` [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 Andrew Morton
2005-11-18 4:11 ` Dave Jones
2005-11-19 0:34 ` Sam Ravnborg
2005-11-19 0:39 ` Dave Jones
2005-11-19 1:19 ` David S. Miller
2005-11-19 20:44 ` Adrian Bunk
2005-11-19 20:51 ` Adrian Bunk
2005-11-19 21:01 ` Sam Ravnborg
2005-11-20 23:27 ` Pavel Machek
2005-11-21 4:27 ` David S. Miller
2005-11-19 13:44 ` Jesper Juhl
-- strict thread matches above, loose matches on Subject: below --
2006-10-02 21:49 Undefined '.bus_to_virt', '.virt_to_bus' causes compile error on Powerpc 64-bit Judith Lebzelter
2006-10-02 23:44 ` Adrian Bunk
2006-10-03 1:22 ` [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 Adrian Bunk
2006-10-03 1:48 ` Nicholas Miell
2006-10-03 1:58 ` Adrian Bunk
2006-10-03 2:55 ` Nicholas Miell
2006-10-03 4:37 ` Benjamin Herrenschmidt
2006-10-03 11:29 ` Alan Cox
2006-10-03 4:37 ` Benjamin Herrenschmidt
2006-10-03 4:44 ` Andrew Morton
2006-10-03 4:49 ` Benjamin Herrenschmidt
2006-10-03 4:55 ` Andrew Morton
2006-10-03 5:07 ` Adrian Bunk
2006-10-03 9:36 ` Stefan Richter
2006-10-03 11:24 ` Alan Cox
2006-07-06 22:30 Adrian Bunk
2006-06-26 15:10 Adrian Bunk
2006-06-26 15:38 ` Dave Jones
2006-06-26 15:46 ` Arjan van de Ven
2006-06-26 15:54 ` Dave Jones
2006-06-27 14:27 ` Jan Engelhardt
2006-06-27 14:42 ` Arjan van de Ven
2006-06-27 15:17 ` Alan Cox
2006-06-27 19:09 ` Jan Engelhardt
2006-06-27 19:17 ` Arjan van de Ven
2006-06-26 16:14 ` Adrian Bunk
2006-06-26 16:45 ` Dave Jones
2006-06-26 15:48 ` Alan Cox
2006-04-27 20:33 Adrian Bunk
[not found] <fa.mZJQjHk9A5D4GHpUn7lttlNhH5U@ifi.uio.no>
[not found] ` <fa.aQp/JAmWqmBjqeleRNK2yrIEx2o@ifi.uio.no>
2006-04-22 21:57 ` Dave Olson
2006-04-18 22:07 Adrian Bunk
2006-04-18 22:19 ` Roland Dreier
[not found] ` <20060419051355.GI4825@rhun.haifa.ibm.com>
2006-04-19 18:07 ` Adrian Bunk
2006-04-19 18:21 ` linux-os (Dick Johnson)
2006-04-19 19:23 ` Arjan van de Ven
[not found] ` <20060419184957.GK4825@rhun.haifa.ibm.com>
2006-04-19 22:55 ` Adrian Bunk
2006-01-06 13:27 Adrian Bunk
2006-01-07 9:51 ` Andrew Morton
2006-01-07 10:53 ` Adrian Bunk
2005-12-13 17:02 Adrian Bunk
2005-11-23 22:34 Adrian Bunk
2005-11-07 20:03 [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS Adrian Bunk
2005-11-10 12:28 ` Andrew Morton
2005-11-11 2:12 ` Adrian Bunk
2005-11-11 2:24 ` Andrew Morton
2005-11-11 20:18 ` Adrian Bunk
2005-11-11 20:20 ` Adrian Bunk
2005-11-12 4:34 ` [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051117.194239.37311109.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®