From: Andrew Morton <akpm@osdl.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org, colpatch@us.ibm.com,
manfred@colorfullife.com
Subject: Re: [PATCH 5/5] slab: fix code formatting
Date: Fri, 18 Nov 2005 18:52:49 -0800 [thread overview]
Message-ID: <20051118185249.1c0be396.akpm@osdl.org> (raw)
In-Reply-To: <iq5upx.mfs45p.e0u0z2lxcapeynwcg6471p8z4.beaver@cs.helsinki.fi>
Pekka Enberg <penberg@cs.helsinki.fi> wrote:
>
> The slab allocator code is inconsistent in coding style and messy. For this
> patch, I ran Lindent for mm/slab.c and fixed up goofs by hand.
>
> ...
>
> slab.c | 1089 ++++++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 571 insertions(+), 518 deletions(-)
Heh. We've been patching slab.c at over one patch per week for six months.
Chances are I'll drop this one like a hot potato when something else comes
along. We'll see.
Yes, one does need to fix up Lindent's leftovers by hand - I'll take a look
too.
And yes, slab.c is rather hard on the eyes.
next parent reply other threads:[~2005-11-19 2:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <iq5ups.cbvcqc.2og64wsnmfcmozvr6ubchx30k.beaver@cs.helsinki.fi>
[not found] ` <iq5upx.mfs45p.e0u0z2lxcapeynwcg6471p8z4.beaver@cs.helsinki.fi>
2005-11-19 2:52 ` Andrew Morton [this message]
2005-11-18 17:20 [PATCH 4/5] slab: extract slab order calculation to separate function Pekka Enberg
2005-11-18 17:20 ` [PATCH 5/5] slab: fix code formatting Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051118185249.1c0be396.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®