From: Jeff Garzik <jgarzik@pobox.com>
To: Neil Brown <neilb@suse.de>
Cc: sander@humilis.net, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, reiserfs-dev@namesys.com
Subject: Re: Please help me understand ->writepage. Was Re: segfault mdadm --write-behind, 2.6.14-mm2 (was: Re: RAID1 ramdisk patch)
Date: Mon, 21 Nov 2005 18:30:41 -0500 [thread overview]
Message-ID: <20051121233041.GC24565@havoc.gtf.org> (raw)
In-Reply-To: <17282.21309.229128.930997@cse.unsw.edu.au>
On Tue, Nov 22, 2005 at 10:07:41AM +1100, Neil Brown wrote:
> To write the pages out it effectively does ->prepare_write,
> ->commit_write, and then ->writepage.
> I'm not sure that prepare/commit is needed, but they don't seem to be
> the problem. writepage is.
That's a bit weird. Typically you have two separate callpaths,
non-page-aligned (prepare_write + commit_write) or writepage(s).
Not both.
Jeff
next prev parent reply other threads:[~2005-11-21 23:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-05 0:46 RAID1 ramdisk patch Wilco Baan Hofman
2005-09-05 1:27 ` Neil Brown
2005-09-05 7:40 ` Wilco Baan Hofman
2005-11-16 13:36 ` segfault mdadm --write-behind, 2.6.14-mm2 (was: Re: RAID1 ramdisk patch) Sander
2005-11-16 22:20 ` Andrew Morton
2005-11-16 23:08 ` Neil Brown
2005-11-17 7:50 ` Sander
2005-11-17 10:12 ` Sander
2005-11-17 10:15 ` Sander
2005-11-21 23:07 ` Please help me understand ->writepage. Was " Neil Brown
2005-11-21 23:30 ` Jeff Garzik [this message]
2005-11-21 23:51 ` Andrew Morton
2005-11-22 3:12 ` Neil Brown
2005-11-22 3:47 ` Andrew Morton
2005-11-22 10:34 ` Sander
2005-11-24 5:41 ` Please help me understand reiser4_writepage. " Neil Brown
2005-11-22 12:00 ` Please help me understand ->writepage. " Anton Altaparmakov
2005-11-24 5:29 ` Neil Brown
2005-11-18 14:18 ` segfault mdadm --write-behind, 2.6.14-mm2 Vladimir V. Saveliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051121233041.GC24565@havoc.gtf.org \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=reiserfs-dev@namesys.com \
--cc=sander@humilis.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®